From mboxrd@z Thu Jan 1 00:00:00 1970 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935355AbeAHQ6S (ORCPT + 1 other); Mon, 8 Jan 2018 11:58:18 -0500 Received: from mga05.intel.com ([192.55.52.43]:38741 "EHLO mga05.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S935329AbeAHQ6P (ORCPT ); Mon, 8 Jan 2018 11:58:15 -0500 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,330,1511856000"; d="scan'208";a="19248144" Date: Mon, 8 Jan 2018 22:32:24 +0530 From: Vinod Koul To: Rob Herring Cc: linux-kernel@vger.kernel.org, Andy Gross , David Brown , Dan Williams , linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org, dmaengine@vger.kernel.org Subject: Re: [PATCH] dmaengine: qcom_hidma: simplify DT resource parsing Message-ID: <20180108170224.GI18649@localhost> References: <20180104224542.15333-2-robh@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180104224542.15333-2-robh@kernel.org> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: On Thu, Jan 04, 2018 at 04:45:40PM -0600, Rob Herring wrote: > The hidma driver open codes populating address and IRQ resources from DT. > We have standard functions of_address_to_resource and of_irq_to_resource > for this, so use them instead. > > The DT binding states each child should have 2 addresses and 1 IRQ, so we > can simplify the logic and do a fixed size resource allocation. Using the > standard of_address_to_resource will also do any address translation which > was missing. Applied, thanks -- ~Vinod