From mboxrd@z Thu Jan  1 00:00:00 1970
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1753760AbeAHRg5 (ORCPT <rfc822;ralf@linux-mips.org> + 1 other);
        Mon, 8 Jan 2018 12:36:57 -0500
Received: from mail-wm0-f65.google.com ([74.125.82.65]:35572 "EHLO
        mail-wm0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1752264AbeAHRgy (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 8 Jan 2018 12:36:54 -0500
X-Google-Smtp-Source: ACJfBotB+8hcyZsV6ez8/Eb5R2M0ZAR310Y8sSNauqHJVA5uYugUrXbSQAec5wZwEuFk4IpAnweBXQ==
Date: Mon, 8 Jan 2018 18:36:50 +0100
From: Ingo Molnar <mingo@kernel.org>
To: Borislav Petkov <bp@suse.de>
Cc: Arnd Bergmann <arnd@arndb.de>,
        "kernelci.org bot" <bot@kernelci.org>,
        Kernel Build Reports Mailman List 
        <kernel-build-reports@lists.linaro.org>,
        Hugh Dickins <hughd@google.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        the arch/x86 maintainers <x86@kernel.org>,
        "4.4.x" <stable@vger.kernel.org>
Subject: Re: stable-rc/linux-4.4.y build: 178 builds: 7 failed, 171 passed, 8
 errors (v4.4.110-23-g49278737d445)
Message-ID: <20180108173650.b6ip2yaycr47feib@gmail.com>
References: <5a537ac1.b0abdf0a.c8456.4e12@mx.google.com>
 <CAK8P3a3Xqe_Jmezsn+iLdYkLJDvW+FFy6t-RWFM9WKS6uvY5GQ@mail.gmail.com>
 <20180108160646.tqdgojirykmhsezn@pd.tnic>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20180108160646.tqdgojirykmhsezn@pd.tnic>
User-Agent: NeoMutt/20170609 (1.8.3)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>


* Borislav Petkov <bp@suse.de> wrote:

> On Mon, Jan 08, 2018 at 03:43:11PM +0100, Arnd Bergmann wrote:
> > This comes from 0cbf2b590bea ("Map the vsyscall page with _PAGE_USER")
> > which adds a line 'bool vsyscall_enabled(void) { return false; }' that
> > presumably
> > should have been 'static inline'.
> 
> Yeah, thanks Arnd.
> 
> @Greg, please fold this in:
> 
> ---
> diff --git a/arch/x86/include/asm/vsyscall.h b/arch/x86/include/asm/vsyscall.h
> index d10cabb..4865e10 100644
> --- a/arch/x86/include/asm/vsyscall.h
> +++ b/arch/x86/include/asm/vsyscall.h
> @@ -19,7 +19,7 @@ static inline bool emulate_vsyscall(struct pt_regs *regs, unsigned long address)
>  {
>  	return false;
>  }
> -bool vsyscall_enabled(void) { return false; }
> +static inline bool vsyscall_enabled(void) { return false; }

Hm, which are the underlying upstream commits - am I missing something?

Thanks,

	Ingo