linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Alexey Dobriyan <adobriyan@gmail.com>
To: tim.c.chen@linux.intel.com, aarcange@redhat.com
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 4/8] x86/spec_ctrl: Add sysctl knobs to enable/disable SPEC_CTRL feature
Date: Mon, 8 Jan 2018 20:43:40 +0300	[thread overview]
Message-ID: <20180108174340.GA7310@avx2> (raw)

> +	len = sprintf(buf, "%d\n", READ_ONCE(*field));

READ_ONCE isn't necessary as there is only one read being made.

> +	len = min(count, sizeof(buf) - 1);
> +	if (copy_from_user(buf, user_buf, len))
> +		return -EFAULT;
> +
> +	buf[len] = '\0';
> +	if (kstrtouint(buf, 0, &enable))
> +		return -EINVAL;

There is kstrto*_from_user().

             reply	other threads:[~2018-01-08 17:43 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-08 17:43 Alexey Dobriyan [this message]
2018-01-08 18:30 ` [PATCH v2 4/8] x86/spec_ctrl: Add sysctl knobs to enable/disable SPEC_CTRL feature Andrea Arcangeli
  -- strict thread matches above, loose matches on Subject: below --
2018-01-06  2:12 [PATCH v2 0/8] IBRS patch series Tim Chen
2018-01-06  2:12 ` [PATCH v2 4/8] x86/spec_ctrl: Add sysctl knobs to enable/disable SPEC_CTRL feature Tim Chen
2018-01-06  3:12   ` Dave Hansen
2018-01-08 12:47     ` Peter Zijlstra
2018-01-08 16:14       ` Peter Zijlstra
2018-01-08 17:28         ` Tim Chen
2018-01-08 17:42           ` Peter Zijlstra
2018-01-08 19:34             ` Woodhouse, David
2018-01-08 19:52               ` Lu, Hongjiu
2018-01-09 10:40             ` Thomas Gleixner
2018-01-09 17:55               ` Tim Chen
2018-01-09 18:13                 ` David Woodhouse
2018-01-09 20:31                   ` Tim Chen
2018-01-27 13:59         ` Konrad Rzeszutek Wilk
2018-01-27 14:26           ` David Woodhouse
2018-01-06  8:54   ` Greg KH
2018-01-06 18:10     ` Tim Chen
2018-01-06 21:25       ` Konrad Rzeszutek Wilk
2018-01-07  8:20         ` Greg KH
2018-01-06 14:41   ` Konrad Rzeszutek Wilk
2018-01-06 17:33     ` Dave Hansen
2018-01-06 17:41       ` Van De Ven, Arjan
2018-01-06 19:22         ` Dave Hansen
2018-01-06 19:47           ` Thomas Gleixner
2018-01-06 21:32             ` Konrad Rzeszutek Wilk
2018-01-06 21:34               ` Van De Ven, Arjan
2018-01-06 21:41                 ` Konrad Rzeszutek Wilk
2018-01-06 21:44                   ` Van De Ven, Arjan
2018-01-06 21:39               ` Thomas Gleixner
2018-01-06 18:23       ` Tim Chen
2018-01-06 18:20     ` Tim Chen
2018-01-08 15:08   ` Peter Zijlstra
2018-01-08 15:29     ` Van De Ven, Arjan
2018-01-08 17:02       ` Tim Chen
2018-01-08 15:11   ` Peter Zijlstra
2018-01-08 15:15   ` Peter Zijlstra
2018-01-08 15:53   ` Peter Zijlstra
2018-01-09  0:29   ` Borislav Petkov
2018-01-09 18:05     ` Tim Chen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180108174340.GA7310@avx2 \
    --to=adobriyan@gmail.com \
    --cc=aarcange@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tim.c.chen@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).