From mboxrd@z Thu Jan 1 00:00:00 1970 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754523AbeAIAYR (ORCPT + 1 other); Mon, 8 Jan 2018 19:24:17 -0500 Received: from mga01.intel.com ([192.55.52.88]:49812 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751835AbeAIAYQ (ORCPT ); Mon, 8 Jan 2018 19:24:16 -0500 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,333,1511856000"; d="scan'208";a="9694591" Date: Mon, 8 Jan 2018 16:24:07 -0800 From: Andi Kleen To: David Woodhouse Cc: Andi Kleen , pjt@google.com, linux-kernel@vger.kernel.org, torvalds@linux-foundation.org, gregkh@linux-foundation.org, tim.c.chen@linux.intel.com, dave.hansen@intel.com, tglx@linutronix.de, peterz@infradead.org, luto@amacapital.net Subject: Re: [PATCH] x86/retpoline: Also fill return buffer after idle Message-ID: <20180109002407.GF6718@tassilo.jf.intel.com> References: <20180108235126.28736-1-andi@firstfloor.org> <1515456009.4423.63.camel@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1515456009.4423.63.camel@infradead.org> User-Agent: Mutt/1.9.1 (2017-09-22) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: > Probably doesn't matter right there but it's going to end up being used > elsewhere with IBRS/IBPB, and the compiler is going to think it needs > to save all the call-clobbered registers for that. Do we want to make > it use inline asm instead? You mean KVM? All the other places have lots of other calls too, so the registers are likely already clobbered. -Andi