From mboxrd@z Thu Jan 1 00:00:00 1970 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755895AbeAIDh6 (ORCPT + 1 other); Mon, 8 Jan 2018 22:37:58 -0500 Received: from mail-qk0-f177.google.com ([209.85.220.177]:39307 "EHLO mail-qk0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755786AbeAIDh5 (ORCPT ); Mon, 8 Jan 2018 22:37:57 -0500 X-Google-Smtp-Source: ACJfBos/e8vmNVKx9fCRwsjm+8S17jSPghaTDtHLB3Y3KeziSUttFoOrINvG2hyxbBnBj2KA3k7rQw== Date: Mon, 8 Jan 2018 19:37:48 -0800 From: Tejun Heo To: "jianchao.wang" Cc: jbacik@fb.com, jack@suse.cz, axboe@kernel.dk, clm@fb.com, kernel-team@fb.com, linux-kernel@vger.kernel.org, linux-btrfs@vger.kernel.org, peterz@infradead.org, Bart.VanAssche@wdc.com Subject: Re: [PATCH 5/7] blk-mq: remove REQ_ATOM_COMPLETE usages from blk-mq Message-ID: <20180109033748.GA3668920@devbig577.frc2.facebook.com> References: <20171216120726.517153-1-tj@kernel.org> <20171216120726.517153-6-tj@kernel.org> <64dfa760-d433-1537-9bc6-b12cda3c9dc6@oracle.com> <20171221135051.GE1084507@devbig577.frc2.facebook.com> <4e5aa629-f341-d077-961b-c778ceb31154@oracle.com> <20180108172723.GY3668920@devbig577.frc2.facebook.com> <9b367cee-ecd8-cd45-9bdb-e79c29d956dd@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <9b367cee-ecd8-cd45-9bdb-e79c29d956dd@oracle.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: Hello, On Tue, Jan 09, 2018 at 11:08:04AM +0800, jianchao.wang wrote: > > But what'd prevent the completion reinitializing the request and then > > the actual completion path coming in and completing the request again? > > blk_mark_rq_complete() will gate and ensure there will be only one > __blk_mq_complete_request() to be invoked. Yeah, but then the complete flag will be cleared once completion is done and the request is reinitialized. Thanks. -- tejun