From: Richard Cochran <richardcochran@gmail.com>
To: Fabio Estevam <festevam@gmail.com>
Cc: Yangbo Lu <yangbo.lu@nxp.com>,
Claudiu Manoil <claudiu.manoil@nxp.com>,
netdev@vger.kernel.org,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] net: gianfar_ptp: move set_fipers() to spinlock protecting area
Date: Mon, 8 Jan 2018 19:39:18 -0800 [thread overview]
Message-ID: <20180109033918.gi2m6khssnddiat3@localhost> (raw)
In-Reply-To: <CAOMZO5CGvXbJtuOsnv6uU5pMUw44BC0wOm+QQpkO1vnZUiJEng@mail.gmail.com>
On Mon, Jan 08, 2018 at 10:53:40AM -0200, Fabio Estevam wrote:
> On Mon, Jan 8, 2018 at 8:13 AM, Yangbo Lu <yangbo.lu@nxp.com> wrote:
> > set_fipers() calling should be protected by spinlock.
> > This patch is to move set_fipers() to spinlock protecting
> > area in ptp_gianfar_adjtime() function.
>
> It would be nice to explay why.
Maybe this is important?
/* Caller must hold etsects->lock. */
static void set_fipers(struct etsects *etsects)
{
set_alarm(etsects);
gfar_write(&etsects->regs->tmr_fiper1, etsects->tmr_fiper1);
gfar_write(&etsects->regs->tmr_fiper2, etsects->tmr_fiper2);
}
Thanks,
Richard
prev parent reply other threads:[~2018-01-09 3:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-08 10:13 [PATCH] net: gianfar_ptp: move set_fipers() to spinlock protecting area Yangbo Lu
2018-01-08 12:53 ` Fabio Estevam
2018-01-09 3:23 ` Y.b. Lu
2018-01-09 3:39 ` Richard Cochran [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180109033918.gi2m6khssnddiat3@localhost \
--to=richardcochran@gmail.com \
--cc=claudiu.manoil@nxp.com \
--cc=festevam@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=yangbo.lu@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox