From mboxrd@z Thu Jan 1 00:00:00 1970 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754852AbeAIK2e (ORCPT + 1 other); Tue, 9 Jan 2018 05:28:34 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:39276 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754206AbeAIK2c (ORCPT ); Tue, 9 Jan 2018 05:28:32 -0500 Date: Tue, 9 Jan 2018 11:28:33 +0100 From: Greg Kroah-Hartman To: Peter Rosin Cc: Hans de Goede , linux-kernel@vger.kernel.org Subject: Re: [RESEND PATCH] mux: core: fix double get_device() Message-ID: <20180109102833.GC15608@kroah.com> References: <20180108181952.29194-1-peda@axentia.se> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180108181952.29194-1-peda@axentia.se> User-Agent: Mutt/1.9.2 (2017-12-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: On Mon, Jan 08, 2018 at 07:19:52PM +0100, Peter Rosin wrote: > From: Hans de Goede > > class_find_device already does a get_device on the returned device. > So the device returned by of_find_mux_chip_by_node is already referenced > and we should not reference it again (and unref it on error). > > Signed-off-by: Hans de Goede > Signed-off-by: Peter Rosin > --- > drivers/mux/core.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > Hi Greg, > > Perhaps this was ignored due to more important stuff? Yeah, the past few weeks have been a "bit" busy :( I'll work to queue this up this week, sorry for the delay... thanks, greg k-h