From: Roman Gushchin <guro@fb.com>
To: "Michael Kerrisk (man-pages)" <mtk.manpages@gmail.com>
Cc: "Serge E. Hallyn" <serge@hallyn.com>, Tejun Heo <tj@kernel.org>,
linux-man <linux-man@vger.kernel.org>,
lkml <linux-kernel@vger.kernel.org>, <cgroups@vger.kernel.org>
Subject: Re: cgroups(7): documenting /sys/kernel/cgroup files
Date: Tue, 9 Jan 2018 11:28:18 +0000 [thread overview]
Message-ID: <20180109112811.GA31373@castle.DHCP.thefacebook.com> (raw)
In-Reply-To: <ff431fd8-f1c1-ed8d-2d69-64ea83a8a505@gmail.com>
Hello, Michael!
Overall looks good to me, one small nit below.
On Mon, Jan 08, 2018 at 10:11:43PM +0100, Michael Kerrisk (man-pages) wrote:
> Hello Roman,
>
> I wrote cgroups(7) text below to document the files added by you in
> Linux 4.15. Could you let me know if the following text is okay please:
>
> /sys/kernel/cgroup files
> /sys/kernel/cgroup/delegate (since Linux 4.15)
> This file exports a list of the cgroups v2 files (one per
> line) that are delegatable (i.e., whose ownership should be
> changed to the user ID of the delegatee). In the future,
> the set of delegatable files may change or grow, and this
> file provides a way for the kernel to inform user-space
> applications of which files must be delegated. As at Linux
> 4.15, one sees the following when inspecting this file:
>
> $ cat /sys/kernel/cgroup/delegate
> cgroup.procs
> cgroup.subtree_control
>
> /sys/kernel/cgroup/features (since Linux 4.15)
> Over time, the set of cgroups v2 features that are provided
> by the kernel may change or grow, or some features may not
> be enabled by default. This file provides a way for user-
> space applications to discover what features the running
> kernel supports or has enabled. Features are listed one
^^
I would replace "or" with "and" here.
Please, feel free to add
Reviewed-by: Roman Gushchin <guro@fb.com>
Thank you!
Roman
next prev parent reply other threads:[~2018-01-09 11:28 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-08 21:11 cgroups(7): documenting /sys/kernel/cgroup files Michael Kerrisk (man-pages)
2018-01-09 11:28 ` Roman Gushchin [this message]
2018-01-09 18:52 ` Michael Kerrisk (man-pages)
2018-01-10 4:23 ` Michael Kerrisk (man-pages)
2018-01-10 12:44 ` Roman Gushchin
2018-01-10 14:02 ` Tejun Heo
2018-01-10 14:32 ` Roman Gushchin
2018-01-10 17:31 ` Michael Kerrisk (man-pages)
2018-01-10 17:33 ` Tejun Heo
2018-01-10 17:39 ` Tejun Heo
2018-01-10 17:44 ` Tejun Heo
2018-01-10 19:14 ` Michael Kerrisk (man-pages)
2018-01-10 17:45 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180109112811.GA31373@castle.DHCP.thefacebook.com \
--to=guro@fb.com \
--cc=cgroups@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-man@vger.kernel.org \
--cc=mtk.manpages@gmail.com \
--cc=serge@hallyn.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox