From mboxrd@z Thu Jan  1 00:00:00 1970
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1757105AbeAINFf (ORCPT <rfc822;ralf@linux-mips.org> + 1 other);
        Tue, 9 Jan 2018 08:05:35 -0500
Received: from mail.kernel.org ([198.145.29.99]:35768 "EHLO mail.kernel.org"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1757053AbeAINF3 (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 9 Jan 2018 08:05:29 -0500
DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CACA82064D
Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org
Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=acme@kernel.org
Date: Tue, 9 Jan 2018 10:05:24 -0300
From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Jiri Olsa <jolsa@redhat.com>
Cc: Namhyung Kim <namhyung@kernel.org>, Jiri Olsa <jolsa@kernel.org>,
        Peter Zijlstra <a.p.zijlstra@chello.nl>,
        lkml <linux-kernel@vger.kernel.org>,
        Ingo Molnar <mingo@kernel.org>,
        David Ahern <dsahern@gmail.com>,
        Andi Kleen <ak@linux.intel.com>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        kernel-team@lge.com
Subject: Re: [PATCH 12/12] perf report: Add --task option to display
 monitored tasks
Message-ID: <20180109130524.GA30494@kernel.org>
References: <20180107160356.28203-1-jolsa@kernel.org>
 <20180107160356.28203-13-jolsa@kernel.org>
 <20180109015607.GA7138@sejong>
 <20180109091551.GA11520@krava>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20180109091551.GA11520@krava>
X-Url: http://acmel.wordpress.com
User-Agent: Mutt/1.9.1 (2017-09-22)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>

Em Tue, Jan 09, 2018 at 10:15:51AM +0100, Jiri Olsa escreveu:
> On Tue, Jan 09, 2018 at 10:56:07AM +0900, Namhyung Kim wrote:
> 
> SNIP
> 
> > > +static struct task *task_list(struct task *task, struct machine *machine)
> > > +{
> > > +	struct thread *parent_thread, *thread = task->thread;
> > > +	struct task   *parent_task;
> > > +
> > > +	/* Already listed. */
> > > +	if (!list_empty(&task->list))
> > > +		return NULL;
> > > +
> > > +	/* Last one in the chain. */
> > > +	if (thread->ppid == -1)
> > > +		return task;
> > > +
> > > +	parent_thread = machine__findnew_thread(machine, -1, thread->ppid);
> > 
> > I think it should be machine__find_thread() since creating a new
> > thread at this stage would lack thread->priv anyway.
> 
> ugh, that's right.. I tried to stay safe, but the NULL
> in priv would bring it down anyway
> 
> Arnaldo,
> I already see changed version on top of your branch,
> please let me know if you make also this change or
> I should send v2

I can make the change, thanks!

Just to make sure we're on the same page, just this, right?

diff --git a/tools/perf/builtin-report.c b/tools/perf/builtin-report.c
index 3685ac101b16..e60709fe31ed 100644
--- a/tools/perf/builtin-report.c
+++ b/tools/perf/builtin-report.c
@@ -633,9 +633,9 @@ static struct task *tasks_list(struct task *task, struct machine *machine)
 	if (thread->ppid == -1)
 		return task;
 
-	parent_thread = machine__findnew_thread(machine, -1, thread->ppid);
+	parent_thread = machine__find_thread(machine, -1, thread->ppid);
 	if (!parent_thread)
-		return ERR_PTR(-ENOMEM);
+		return ERR_PTR(-ENOENT);
 
 	parent_task = thread__priv(parent_thread);
 	list_add_tail(&task->list, &parent_task->children);