* [PATCH] staging: pi433: align function parameters with open parenthesis
@ 2018-01-08 17:39 Valentin Vidic
2018-01-09 14:33 ` Greg Kroah-Hartman
0 siblings, 1 reply; 3+ messages in thread
From: Valentin Vidic @ 2018-01-08 17:39 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: Marcin Ciupak, Simon Sandström, Marcus Wolf, devel,
linux-kernel, Valentin Vidic
Fixes checkpatch warnings:
CHECK: Alignment should match open parenthesis
---
drivers/staging/pi433/pi433_if.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/pi433/pi433_if.c b/drivers/staging/pi433/pi433_if.c
index f56425ffbe90..edcd7e798f99 100644
--- a/drivers/staging/pi433/pi433_if.c
+++ b/drivers/staging/pi433/pi433_if.c
@@ -799,7 +799,7 @@ pi433_read(struct file *filp, char __user *buf, size_t size, loff_t *f_pos)
static ssize_t
pi433_write(struct file *filp, const char __user *buf,
- size_t count, loff_t *f_pos)
+ size_t count, loff_t *f_pos)
{
struct pi433_instance *instance;
struct pi433_device *device;
@@ -870,17 +870,17 @@ pi433_ioctl(struct file *filp, unsigned int cmd, unsigned long arg)
switch (cmd) {
case PI433_IOC_RD_TX_CFG:
if (copy_to_user(argp, &instance->tx_cfg,
- sizeof(struct pi433_tx_cfg)))
+ sizeof(struct pi433_tx_cfg)))
return -EFAULT;
break;
case PI433_IOC_WR_TX_CFG:
if (copy_from_user(&instance->tx_cfg, argp,
- sizeof(struct pi433_tx_cfg)))
+ sizeof(struct pi433_tx_cfg)))
return -EFAULT;
break;
case PI433_IOC_RD_RX_CFG:
if (copy_to_user(argp, &device->rx_cfg,
- sizeof(struct pi433_rx_cfg)))
+ sizeof(struct pi433_rx_cfg)))
return -EFAULT;
break;
case PI433_IOC_WR_RX_CFG:
@@ -893,7 +893,7 @@ pi433_ioctl(struct file *filp, unsigned int cmd, unsigned long arg)
}
if (copy_from_user(&device->rx_cfg, argp,
- sizeof(struct pi433_rx_cfg))) {
+ sizeof(struct pi433_rx_cfg))) {
mutex_unlock(&device->rx_lock);
return -EFAULT;
}
--
2.15.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] staging: pi433: align function parameters with open parenthesis
2018-01-08 17:39 [PATCH] staging: pi433: align function parameters with open parenthesis Valentin Vidic
@ 2018-01-09 14:33 ` Greg Kroah-Hartman
2018-01-09 14:39 ` [PATCH v2] " Valentin Vidic
0 siblings, 1 reply; 3+ messages in thread
From: Greg Kroah-Hartman @ 2018-01-09 14:33 UTC (permalink / raw)
To: Valentin Vidic
Cc: devel, linux-kernel, Marcin Ciupak, Marcus Wolf,
Simon Sandström
On Mon, Jan 08, 2018 at 06:39:33PM +0100, Valentin Vidic wrote:
> Fixes checkpatch warnings:
>
> CHECK: Alignment should match open parenthesis
> ---
> drivers/staging/pi433/pi433_if.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
No signed-off-by line :(
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH v2] staging: pi433: align function parameters with open parenthesis
2018-01-09 14:33 ` Greg Kroah-Hartman
@ 2018-01-09 14:39 ` Valentin Vidic
0 siblings, 0 replies; 3+ messages in thread
From: Valentin Vidic @ 2018-01-09 14:39 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: Marcin Ciupak, Simon Sandström, Marcus Wolf, devel,
linux-kernel, Valentin Vidic
Fixes checkpatch warnings:
CHECK: Alignment should match open parenthesis
Signed-off-by: Valentin Vidic <Valentin.Vidic@CARNet.hr>
---
v2: add missing Signed-off-by
drivers/staging/pi433/pi433_if.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/pi433/pi433_if.c b/drivers/staging/pi433/pi433_if.c
index f56425ffbe90..edcd7e798f99 100644
--- a/drivers/staging/pi433/pi433_if.c
+++ b/drivers/staging/pi433/pi433_if.c
@@ -799,7 +799,7 @@ pi433_read(struct file *filp, char __user *buf, size_t size, loff_t *f_pos)
static ssize_t
pi433_write(struct file *filp, const char __user *buf,
- size_t count, loff_t *f_pos)
+ size_t count, loff_t *f_pos)
{
struct pi433_instance *instance;
struct pi433_device *device;
@@ -870,17 +870,17 @@ pi433_ioctl(struct file *filp, unsigned int cmd, unsigned long arg)
switch (cmd) {
case PI433_IOC_RD_TX_CFG:
if (copy_to_user(argp, &instance->tx_cfg,
- sizeof(struct pi433_tx_cfg)))
+ sizeof(struct pi433_tx_cfg)))
return -EFAULT;
break;
case PI433_IOC_WR_TX_CFG:
if (copy_from_user(&instance->tx_cfg, argp,
- sizeof(struct pi433_tx_cfg)))
+ sizeof(struct pi433_tx_cfg)))
return -EFAULT;
break;
case PI433_IOC_RD_RX_CFG:
if (copy_to_user(argp, &device->rx_cfg,
- sizeof(struct pi433_rx_cfg)))
+ sizeof(struct pi433_rx_cfg)))
return -EFAULT;
break;
case PI433_IOC_WR_RX_CFG:
@@ -893,7 +893,7 @@ pi433_ioctl(struct file *filp, unsigned int cmd, unsigned long arg)
}
if (copy_from_user(&device->rx_cfg, argp,
- sizeof(struct pi433_rx_cfg))) {
+ sizeof(struct pi433_rx_cfg))) {
mutex_unlock(&device->rx_lock);
return -EFAULT;
}
--
2.15.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-01-09 14:39 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-01-08 17:39 [PATCH] staging: pi433: align function parameters with open parenthesis Valentin Vidic
2018-01-09 14:33 ` Greg Kroah-Hartman
2018-01-09 14:39 ` [PATCH v2] " Valentin Vidic
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox