From mboxrd@z Thu Jan  1 00:00:00 1970
Date: Tue, 9 Jan 2018 16:34:16 +0100
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Sakari Ailus <sakari.ailus@iki.fi>
Cc: Joe Perches <joe@perches.com>, Don Brace <don.brace@microsemi.com>,
	linux-nvme@lists.infradead.org, Rich Felker <dalias@libc.org>,
	linux-sh@vger.kernel.org, David Airlie <airlied@linux.ie>,
	esc.storagedev@microsemi.com,
	Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
	Heiko Carstens <heiko.carstens@de.ibm.com>,
	alsa-devel@alsa-project.org, dri-devel@lists.freedesktop.org,
	Russell King <linux@armlinux.org.uk>,
	Keith Busch <keith.busch@intel.com>,
	Robert Jarzmik <robert.jarzmik@free.fr>,
	Christoph Hellwig <hch@lst.de>, devel@driverdev.osuosl.org,
	linux-s390@vger.kernel.org,
	"James E.J. Bottomley" <jejb@linux.vnet.ibm.com>,
	Sagi Grimberg <sagi@grimberg.me>,
	Yoshinori Sato <ysato@users.sourceforge.jp>,
	Takashi Iwai <tiwai@suse.com>,
	Sebastian Ott <sebott@linux.vnet.ibm.com>,
	James Smart <james.smart@broadcom.com>, linux-acpi@vger.kernel.org,
	Zhang Rui <rui.zhang@intel.com>, Len Brown <lenb@kernel.org>,
	Dick Kennedy <dick.kennedy@broadcom.com>,
	Corey Minyard <minyard@acm.org>, linux-pm@vger.kernel.org,
	Peter Oberparleiter <oberpar@linux.vnet.ibm.com>,
	intel-gfx@lists.freedesktop.org,
	Haojian Zhuang <haojian.zhuang@gmail.com>,
	Jens Axboe <axboe@fb.com>, Mark Brown <broonie@kernel.org>,
	Harald Freudenberger <freude@de.ibm.com>,
	Jani Nikula <jani.nikula@linux.intel.com>,
	Rodrigo Vivi <rodrigo.vivi@intel.com>,
	Jaroslav Kysela <perex@perex.cz>,
	openipmi-developer@lists.sourceforge.net,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	linux-arm-kernel@lists.infradead.org,
	Alan Cox <alan@linux.intel.com>,
	Eduardo Valentin <edubezval@gmail.com>, linux-scsi@vger.kernel.org,
	"Martin K. Petersen" <martin.petersen@oracle.com>,
	"Rafael J. Wysocki" <rjw@rjwysocki.net>,
	Liam Girdwood <lgirdwood@gmail.com>, linux-kernel@vger.kernel.org,
	Arnd Bergmann <arnd@arndb.de>,
	Sakari Ailus <sakari.ailus@linux.intel.com>,
	Martin Schwidefsky <schwidefsky@de.ibm.com>,
	linux-media@vger.kernel.org, Daniel Mack <daniel@zonque.org>
Subject: Re: [-next PATCH 3/4] treewide: Use DEVICE_ATTR_RO
Message-ID: <20180109153416.GA7780@kroah.com>
References: <cover.1513706701.git.joe@perches.com>
 <2e64e7d278fa9e4e255221fb84717884a7bfb69c.1513706701.git.joe@perches.com>
 <20171221093410.ygvupz3azaccxgnb@valkosipuli.retiisi.org.uk>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20171221093410.ygvupz3azaccxgnb@valkosipuli.retiisi.org.uk>
User-Agent: Mutt/1.9.2 (2017-12-15)
X-Mailing-List: linux-kernel@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>

On Thu, Dec 21, 2017 at 11:34:10AM +0200, Sakari Ailus wrote:
> Hi Joe,
> 
> On Tue, Dec 19, 2017 at 10:15:08AM -0800, Joe Perches wrote:
> > diff --git a/drivers/staging/media/atomisp/pci/atomisp2/hmm/hmm.c b/drivers/staging/media/atomisp/pci/atomisp2/hmm/hmm.c
> > index a1c81c12718c..4338b8a1309f 100644
> > --- a/drivers/staging/media/atomisp/pci/atomisp2/hmm/hmm.c
> > +++ b/drivers/staging/media/atomisp/pci/atomisp2/hmm/hmm.c
> > @@ -158,10 +158,10 @@ static ssize_t dynamic_pool_show(struct device *dev,
> >  	return ret;
> >  };
> >  
> > -static DEVICE_ATTR(active_bo, 0444, active_bo_show, NULL);
> > -static DEVICE_ATTR(free_bo, 0444, free_bo_show, NULL);
> > -static DEVICE_ATTR(reserved_pool, 0444, reserved_pool_show, NULL);
> > -static DEVICE_ATTR(dynamic_pool, 0444, dynamic_pool_show, NULL);
> > +static DEVICE_ATTR_RO(active_bo);
> > +static DEVICE_ATTR_RO(free_bo);
> > +static DEVICE_ATTR_RO(reserved_pool);
> > +static DEVICE_ATTR_RO(dynamic_pool);
> >  
> >  static struct attribute *sysfs_attrs_ctrl[] = {
> >  	&dev_attr_active_bo.attr,
> 
> I have the exact same changes queued up in my tree. As there seem to be no
> dependencies to other patches in your set, how about dropping this chunk?

I've now dropped it, thanks.

greg k-h