public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Tejun Heo <tj@kernel.org>
To: "Michael Kerrisk (man-pages)" <mtk.manpages@gmail.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
	cgroups@vger.kernel.org, lkml <linux-kernel@vger.kernel.org>,
	linux-man <linux-man@vger.kernel.org>,
	"Serge E. Hallyn" <serge@hallyn.com>,
	Mike Galbraith <efault@gmx.de>, Li Zefan <lizefan@huawei.com>,
	Ingo Molnar <mingo@redhat.com>, Paul Turner <pjt@google.com>,
	kernel-team@fb.com, Andy Lutomirski <luto@amacapital.net>,
	Johannes Weiner <hannes@cmpxchg.org>,
	Lauro Venancio <lvenanci@redhat.com>,
	Waiman Long <longman@redhat.com>
Subject: Re: cgroups(7): documenting cgroups v2 thread mode
Date: Tue, 9 Jan 2018 13:10:00 -0800	[thread overview]
Message-ID: <20180109211000.GT3668920@devbig577.frc2.facebook.com> (raw)
In-Reply-To: <b2d54ae2-62db-7402-ed99-7a0e72f90ff4@gmail.com>

Hello,

On Tue, Jan 02, 2018 at 07:24:01PM +0100, Michael Kerrisk (man-pages) wrote:
>        2. We write the string "threaded" to each of the domain invalid
>           cgroups  under  y,  in  order  to  convert  them to the type
>           threaded.  As a consequence of this step, all threads  under
>           the  threaded  root  now  have  the  type  threaded  and the
>           threaded subtree is now fully usable.   The  requirement  to
>           write  "threaded"  to each of these cgroups is somewhat cum‐
>           bersome, but allows for possible future  extensions  to  the
>           thread-mode model.
> 
>           ┌─────────────────────────────────────────────────────┐
>           │FIXME                                                │
>           ├─────────────────────────────────────────────────────┤
>           │Re  the preceding paragraphs... Are there other rea‐ │
>           │sosn  for  the  (cumbersome)  requirement  to  write │
>           │'threaded'  to  each of the cgroup.type files in the │
>           │threaded subtrees? Tejun Heo mentioned  the  follow‐ │
>           │ing:                                                 │
>           │                                                     │
>           │    Consistency w/ the cgroups right under the root  │
>           │    cgroup.  Because they can be both domains and    │
>           │    threadroots, we can't switch the children over   │
>           │    to thread mode automatically.  Doing that for    │
>           │    cgroups further down in the hierarchy would be   │
>           │    really inconsistent.                             │
>           │                                                     │
>           │But,  it's  not  clear  to  me  how  "Doing that for │
>           │cgroups further  down  in  the  hierarchy  would  be │
>           │really inconsistent", since in the current implemen‐ │
>           │tation, those same thread groups  are  converted  to │
>           │"domain invalid" type.  What am I missing?           │
>           └─────────────────────────────────────────────────────┘

Yeah, I was confused with an earlier varient where we were marking
threaded domains instead of threaded roots.  It's mostly about future
extensibility (especially as Waiman was proposing related changes
there) and not doing things automatically / recursively if possible.

Looks good to me.

Thanks.

-- 
tejun

  reply	other threads:[~2018-01-09 21:10 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-02 18:24 cgroups(7): documenting cgroups v2 thread mode Michael Kerrisk (man-pages)
2018-01-09 21:10 ` Tejun Heo [this message]
2018-01-09 22:52   ` Michael Kerrisk (man-pages)
2018-01-09 22:54   ` Michael Kerrisk (man-pages)
2018-01-10 14:47     ` Tejun Heo
2018-01-10 22:18       ` Michael Kerrisk (man-pages)
2018-01-10 22:29         ` Tejun Heo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180109211000.GT3668920@devbig577.frc2.facebook.com \
    --to=tj@kernel.org \
    --cc=cgroups@vger.kernel.org \
    --cc=efault@gmx.de \
    --cc=hannes@cmpxchg.org \
    --cc=kernel-team@fb.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-man@vger.kernel.org \
    --cc=lizefan@huawei.com \
    --cc=longman@redhat.com \
    --cc=luto@amacapital.net \
    --cc=lvenanci@redhat.com \
    --cc=mingo@redhat.com \
    --cc=mtk.manpages@gmail.com \
    --cc=peterz@infradead.org \
    --cc=pjt@google.com \
    --cc=serge@hallyn.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox