From: Johan Hovold <johan@kernel.org>
To: "Ji-Ze Hong (Peter Hong)" <hpeter@gmail.com>
Cc: Johan Hovold <johan@kernel.org>,
gregkh@linuxfoundation.org, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org, peter_hong@fintek.com.tw,
"Ji-Ze Hong (Peter Hong)" <hpeter+linux_kernel@gmail.com>
Subject: Re: [PATCH V2 5/5] usb: serial: f81534: fix tx error on some baud rate
Date: Wed, 10 Jan 2018 09:50:37 +0100 [thread overview]
Message-ID: <20180110085037.GW11344@localhost> (raw)
In-Reply-To: <747ab8c9-50cc-2bbb-6f58-758e3361cbe2@gmail.com>
On Wed, Jan 10, 2018 at 01:42:32PM +0800, Ji-Ze Hong (Peter Hong) wrote:
> Hi Johan,
>
> Johan Hovold 於 2018/1/9 下午 07:32 寫道:
> > On Thu, Jan 04, 2018 at 10:29:21AM +0800, Ji-Ze Hong (Peter Hong) wrote:
> >> + /*
> >> + * We'll make tx frame error when baud rate from 384~500kps. So we'll
> >> + * delay all tx data frame with 1bit.
> >> + */
> >> + port_priv->shadow_clk |= F81534_CLK_TX_DELAY_1BIT;
> >
> > You don't wan't to enable this only for the affected rates?
> >
>
> This bit will control all transmit TX frame always delay 1 bit
> on enabled, but It'll transmit TX frame randomly delay 1 bit on
> disabled.
>
> We had tested it with BurnInTest to check the performance,
> It'll not make the performance regression. So we'll directly add
> it on all baud rate.
Ok, thanks for confirming.
Johan
next prev parent reply other threads:[~2018-01-10 8:50 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-04 2:29 [PATCH V2 1/5] usb: serial: f81534: add high baud rate support Ji-Ze Hong (Peter Hong)
2018-01-04 2:29 ` [PATCH V2 2/5] usb: serial: f81534: add auto RTS direction support Ji-Ze Hong (Peter Hong)
2018-01-09 11:14 ` Johan Hovold
2018-01-04 2:29 ` [PATCH V2 3/5] usb: serial: f81534: add output pin control Ji-Ze Hong (Peter Hong)
2018-01-09 11:19 ` Johan Hovold
2018-01-04 2:29 ` [PATCH V2 4/5] usb: serial: f81534: add H/W disable port support Ji-Ze Hong (Peter Hong)
2018-01-09 11:29 ` Johan Hovold
2018-01-04 2:29 ` [PATCH V2 5/5] usb: serial: f81534: fix tx error on some baud rate Ji-Ze Hong (Peter Hong)
2018-01-09 11:32 ` Johan Hovold
2018-01-10 5:42 ` Ji-Ze Hong (Peter Hong)
2018-01-10 8:50 ` Johan Hovold [this message]
2018-01-09 11:08 ` [PATCH V2 1/5] usb: serial: f81534: add high baud rate support Johan Hovold
2018-01-10 5:30 ` Ji-Ze Hong (Peter Hong)
2018-01-10 8:49 ` Johan Hovold
2018-01-10 9:16 ` Ji-Ze Hong (Peter Hong)
2018-01-10 9:27 ` Johan Hovold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180110085037.GW11344@localhost \
--to=johan@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=hpeter+linux_kernel@gmail.com \
--cc=hpeter@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=peter_hong@fintek.com.tw \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).