From: Stephen Hemminger <stephen@networkplumber.org>
To: Arnd Bergmann <arnd@arndb.de>
Cc: "K. Y. Srinivasan" <kys@microsoft.com>,
Haiyang Zhang <haiyangz@microsoft.com>,
Stephen Hemminger <sthemmin@microsoft.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
devel@linuxdriverproject.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] uio_hv_generic: fix type mismatch warnings
Date: Wed, 10 Jan 2018 08:57:54 -0800 [thread overview]
Message-ID: <20180110085754.7a628b82@xeon-e3> (raw)
In-Reply-To: <20180110164250.1103858-1-arnd@arndb.de>
On Wed, 10 Jan 2018 17:42:38 +0100
Arnd Bergmann <arnd@arndb.de> wrote:
> I moved the virt_to_phys() conversion into hv_uio_probe() as part of
> a warning fix. Stephen's cleanup to remove the private mmap() function
> seems reasonable, but part of it reverted the change that I did to
> hide the warnings, so they are back now:
>
> drivers/uio/uio_hv_generic.c: In function 'hv_uio_probe':
> drivers/uio/uio_hv_generic.c:123:5: error: cast from pointer to integer of different size [-Werror=pointer-to-int-cast]
> drivers/uio/uio_hv_generic.c:130:5: error: cast from pointer to integer of different size [-Werror=pointer-to-int-cast]
> drivers/uio/uio_hv_generic.c:136:5: error: cast from pointer to integer of different size [-Werror=pointer-to-int-cast]
>
> The type mismatch is now the result of the uio_mmap() definition, and
> the best way I see from here is to shut them up with a uintptr_t cast.
>
> Fixes: 9c40546c012c ("uio_hv_generic: use standard mmap for resources")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Thanks. Not sure why I don't see these.
Signed-off-by: Stephen Hemminger <sthemmin@microsoft.com>
next prev parent reply other threads:[~2018-01-10 16:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-10 16:42 [PATCH] uio_hv_generic: fix type mismatch warnings Arnd Bergmann
2018-01-10 16:57 ` Stephen Hemminger [this message]
2018-01-10 17:14 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180110085754.7a628b82@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=arnd@arndb.de \
--cc=devel@linuxdriverproject.org \
--cc=gregkh@linuxfoundation.org \
--cc=haiyangz@microsoft.com \
--cc=kys@microsoft.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sthemmin@microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox