From mboxrd@z Thu Jan 1 00:00:00 1970 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965904AbeAJQ56 (ORCPT + 1 other); Wed, 10 Jan 2018 11:57:58 -0500 Received: from mail-pl0-f67.google.com ([209.85.160.67]:33602 "EHLO mail-pl0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752043AbeAJQ55 (ORCPT ); Wed, 10 Jan 2018 11:57:57 -0500 X-Google-Smtp-Source: ACJfBosiTPW2pmWrDmzSlcAMdAIpZzyORv0lL2QaZmudVvh0YVg7ZMo0MssGRUcSbqSq1XucdYIlGw== Date: Wed, 10 Jan 2018 08:57:54 -0800 From: Stephen Hemminger To: Arnd Bergmann Cc: "K. Y. Srinivasan" , Haiyang Zhang , Stephen Hemminger , Greg Kroah-Hartman , devel@linuxdriverproject.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] uio_hv_generic: fix type mismatch warnings Message-ID: <20180110085754.7a628b82@xeon-e3> In-Reply-To: <20180110164250.1103858-1-arnd@arndb.de> References: <20180110164250.1103858-1-arnd@arndb.de> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: On Wed, 10 Jan 2018 17:42:38 +0100 Arnd Bergmann wrote: > I moved the virt_to_phys() conversion into hv_uio_probe() as part of > a warning fix. Stephen's cleanup to remove the private mmap() function > seems reasonable, but part of it reverted the change that I did to > hide the warnings, so they are back now: > > drivers/uio/uio_hv_generic.c: In function 'hv_uio_probe': > drivers/uio/uio_hv_generic.c:123:5: error: cast from pointer to integer of different size [-Werror=pointer-to-int-cast] > drivers/uio/uio_hv_generic.c:130:5: error: cast from pointer to integer of different size [-Werror=pointer-to-int-cast] > drivers/uio/uio_hv_generic.c:136:5: error: cast from pointer to integer of different size [-Werror=pointer-to-int-cast] > > The type mismatch is now the result of the uio_mmap() definition, and > the best way I see from here is to shut them up with a uintptr_t cast. > > Fixes: 9c40546c012c ("uio_hv_generic: use standard mmap for resources") > Signed-off-by: Arnd Bergmann Thanks. Not sure why I don't see these. Signed-off-by: Stephen Hemminger