From: marcus.wolf@smarthome-wolf.de
To: gregkh@linuxfoundation.org, joe@perches.com
Cc: Valentin.Vidic@CARNet.hr, davem@davemloft.net,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
marcin.s.ciupak@gmail.com, linux@wolf-entwicklungen.de,
simon@nikanor.nu
Subject: Re: [PATCH] staging: pi433: remove unnecessary parentheses
Date: Wed, 10 Jan 2018 10:49:23 +0100 (CET) [thread overview]
Message-ID: <20180110094923.C78122CE00CD@dd39320.kasserver.com> (raw)
In-Reply-To: <1515575145.9619.146.camel@perches.com>
Joe Perches schrieb am 10.01.2018 10:05:
> On Wed, 2018-01-10 at 09:44 +0100, Greg Kroah-Hartman wrote:
> > On Tue, Jan 09, 2018 at 11:42:16AM -0800, Joe Perches wrote:
> > > if (a == b && c == d)
> > > is pretty trivial.
> >
> > But again, don't do that.
>
> <shrug> We disagree. Life goes on.
>
> cheers, Joe
>
>
For me the line above isn't obvious and easy to read. If I would be in doubt, whether it really performs correctly, I would have to ask the c-guide, to be absolutely shure.
But to be honest: If I need to find a bug arround taht lines, I wouldn't ask the c-guide, but simply add some (). Then it would be 100% clear and no one would be in doubt any more.
What's the disadvantage of () to emphasise waht is going on. An other Option for me would be, to spend a command line and write that info in form of a comment.
Just my opinion and the way, I would go on if I am in doubt and need to find a bug.
Cheers,
Marcus
prev parent reply other threads:[~2018-01-10 9:49 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-08 17:38 [PATCH] staging: pi433: remove unnecessary parentheses Valentin Vidic
2018-01-09 14:31 ` Greg Kroah-Hartman
2018-01-09 19:21 ` Joe Perches
2018-01-09 19:28 ` Greg Kroah-Hartman
2018-01-09 19:42 ` Joe Perches
2018-01-10 8:44 ` Greg Kroah-Hartman
2018-01-10 9:05 ` Joe Perches
2018-01-10 9:49 ` marcus.wolf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180110094923.C78122CE00CD@dd39320.kasserver.com \
--to=marcus.wolf@smarthome-wolf.de \
--cc=Valentin.Vidic@CARNet.hr \
--cc=davem@davemloft.net \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@wolf-entwicklungen.de \
--cc=marcin.s.ciupak@gmail.com \
--cc=simon@nikanor.nu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox