From: Mark Brown <broonie@kernel.org>
To: Takashi Iwai <tiwai@suse.de>
Cc: Ryan Lee <ryans.lee@maximintegrated.com>,
alsa-devel@alsa-project.org, lgirdwood@gmail.com,
ryan.lee.maxim@gmail.com, perex@perex.cz,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/4] ASoC: max98373: Changed SPDX header in C++ comments style
Date: Wed, 10 Jan 2018 10:29:40 +0000 [thread overview]
Message-ID: <20180110102940.GA13207@sirena.org.uk> (raw)
In-Reply-To: <s5htvvuxbcr.wl-tiwai@suse.de>
[-- Attachment #1: Type: text/plain, Size: 791 bytes --]
On Wed, Jan 10, 2018 at 11:21:56AM +0100, Takashi Iwai wrote:
> Mark Brown wrote:
> > On Tue, Jan 09, 2018 at 09:01:58PM -0800, Ryan Lee wrote:
> > > @@ -1,4 +1,4 @@
> > > -/* SPDX-License-Identifier: GPL-2.0 */
> > > +// SPDX-License-Identifier: GPL-2.0
> > > /* Copyright (c) 2017, Maxim Integrated */
> > Please change the entire header to C++, mixing C and C++ on adjacent
> > lines looks ugly.
> I'm not sure whether it's a good direction to go, either.
> I rather wonder why SPDX line *must* be in C++ comment style...
Apparently it's to remove any ambiguity for the tooling or something,
plus Linus decided he likes C++ comments.
I don't understand why this isn't done as a macro like MODULE_LICENSE()
and so on but the decision was rushed through and not really publicised
:9
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2018-01-10 10:29 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-10 5:01 [PATCH 1/4] ASoC: max98373: Changed SPDX header in C++ comments style Ryan Lee
2018-01-10 5:01 ` [PATCH 2/4] ASoC: max98373: Added missing blank lines Ryan Lee
2018-01-10 11:13 ` Applied "ASoC: max98373: Added missing blank lines" to the asoc tree Mark Brown
2018-01-10 5:02 ` [PATCH 3/4] ASoC: max98373: Added TDM off if parameters are all zeroes Ryan Lee
2018-01-10 11:13 ` Applied "ASoC: max98373: Added TDM off if parameters are all zeroes" to the asoc tree Mark Brown
2018-01-10 5:02 ` [PATCH 4/4] ASoC: max98373: Modified control names for TLV controls Ryan Lee
2018-01-10 11:13 ` Applied "ASoC: max98373: Modified control names for TLV controls" to the asoc tree Mark Brown
2018-01-10 10:15 ` [PATCH 1/4] ASoC: max98373: Changed SPDX header in C++ comments style Mark Brown
2018-01-10 10:21 ` Takashi Iwai
2018-01-10 10:29 ` Mark Brown [this message]
2018-01-18 21:35 ` Ryan Lee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180110102940.GA13207@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=ryan.lee.maxim@gmail.com \
--cc=ryans.lee@maximintegrated.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox