public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Tejun Heo <tj@kernel.org>
To: "Michael Kerrisk (man-pages)" <mtk.manpages@gmail.com>
Cc: Roman Gushchin <guro@fb.com>,
	"Serge E. Hallyn" <serge@hallyn.com>,
	linux-man <linux-man@vger.kernel.org>,
	lkml <linux-kernel@vger.kernel.org>,
	"open list:CONTROL GROUP (CGROUP)" <cgroups@vger.kernel.org>
Subject: Re: cgroups(7): documenting /sys/kernel/cgroup files
Date: Wed, 10 Jan 2018 09:39:42 -0800	[thread overview]
Message-ID: <20180110173942.GH3668920@devbig577.frc2.facebook.com> (raw)
In-Reply-To: <20180110173340.GG3668920@devbig577.frc2.facebook.com>

Hello, again.

On Wed, Jan 10, 2018 at 09:33:40AM -0800, Tejun Heo wrote:
> Hello, Michael.
> 
> On Wed, Jan 10, 2018 at 06:31:20PM +0100, Michael Kerrisk (man-pages) wrote:
> > So, I am confused. According to Documentation/cgroup-v2.txt,
> > cgoup.threads is delegated:
> > 
> > [[
> > Model of Delegation
> > ~~~~~~~~~~~~~~~~~~~
> > 
> > A cgroup can be delegated in two ways.  First, to a less privileged
> > user by granting write access of the directory and its "cgroup.procs",
> > "cgroup.threads" and "cgroup.subtree_control" files to the user.
> > Second, if the "nsdelegate" mount option is set, automatically to a
> > cgroup namespace on namespace creation.
> > ]]
> > 
> > So, is that a mistake in that text file?
> 
> Yes, it is.  I probably copy&pasted from an earlier version where we
> were marking threaded domains instead of threaded roots.  Will fix it
> right away.

Jesus christ, sorry.  Roman and the document are right.

* cgroup.type is not delegatble, marking it threaded makes the cgroup
  join the parent's domain.

* cgroup.threads is delegatable, because marking the child cgroups as
  threaded make them join the subtree root, and the threads can be
  dispersed across the parent - the delegated root here - and the
  subtree of the child which is marked threaded.

I'll apply Roman's patch.  Sorry about the confusion.

Thanks.

-- 
tejun

  reply	other threads:[~2018-01-10 17:39 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-08 21:11 cgroups(7): documenting /sys/kernel/cgroup files Michael Kerrisk (man-pages)
2018-01-09 11:28 ` Roman Gushchin
2018-01-09 18:52   ` Michael Kerrisk (man-pages)
2018-01-10  4:23 ` Michael Kerrisk (man-pages)
2018-01-10 12:44   ` Roman Gushchin
2018-01-10 14:02     ` Tejun Heo
2018-01-10 14:32       ` Roman Gushchin
2018-01-10 17:31       ` Michael Kerrisk (man-pages)
2018-01-10 17:33         ` Tejun Heo
2018-01-10 17:39           ` Tejun Heo [this message]
2018-01-10 17:44       ` Tejun Heo
2018-01-10 19:14         ` Michael Kerrisk (man-pages)
2018-01-10 17:45     ` Tejun Heo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180110173942.GH3668920@devbig577.frc2.facebook.com \
    --to=tj@kernel.org \
    --cc=cgroups@vger.kernel.org \
    --cc=guro@fb.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-man@vger.kernel.org \
    --cc=mtk.manpages@gmail.com \
    --cc=serge@hallyn.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox