From mboxrd@z Thu Jan 1 00:00:00 1970 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754287AbeAJTaL (ORCPT + 1 other); Wed, 10 Jan 2018 14:30:11 -0500 Received: from mail-pg0-f66.google.com ([74.125.83.66]:41239 "EHLO mail-pg0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754261AbeAJTaH (ORCPT ); Wed, 10 Jan 2018 14:30:07 -0500 X-Google-Smtp-Source: ACJfBotFqtBlDt5SIntVu/Ud20jf3EZ200MLHF4mT/sJ3TvjNG3qOe4J5kZgmC4gP6NijZOChR4jaw== Date: Wed, 10 Jan 2018 11:30:04 -0800 From: Dmitry Torokhov To: Arnd Bergmann Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] input: of_touchscreen: add MODULE_LICENSE Message-ID: <20180110193004.olysgc36c53m5jae@dtor-ws> References: <20180110163137.543730-1-arnd@arndb.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180110163137.543730-1-arnd@arndb.de> User-Agent: NeoMutt/20170609 (1.8.3) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: On Wed, Jan 10, 2018 at 05:31:26PM +0100, Arnd Bergmann wrote: > The lack of the MODULE_LICENSE tag can lead to a warning here: > > WARNING: modpost: missing MODULE_LICENSE() in drivers/input/touchscreen/of_touchscreen.o > > I'm adding a license and description tag, but no MODULE_AUTHOR() > as this file is a collection of standalone helper functions that > were all added by different developers. > > Signed-off-by: Arnd Bergmann Applied, thank you. > --- > drivers/input/touchscreen/of_touchscreen.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/input/touchscreen/of_touchscreen.c b/drivers/input/touchscreen/of_touchscreen.c > index 8d7f9c8f2771..9642f103b726 100644 > --- a/drivers/input/touchscreen/of_touchscreen.c > +++ b/drivers/input/touchscreen/of_touchscreen.c > @@ -13,6 +13,7 @@ > #include > #include > #include > +#include > > static bool touchscreen_get_prop_u32(struct device *dev, > const char *property, > @@ -185,3 +186,6 @@ void touchscreen_report_pos(struct input_dev *input, > input_report_abs(input, multitouch ? ABS_MT_POSITION_Y : ABS_Y, y); > } > EXPORT_SYMBOL(touchscreen_report_pos); > + > +MODULE_LICENSE("GPL v2"); > +MODULE_DESCRIPTION("Device-tree helpers functions for touchscreen devices"); > -- > 2.9.0 > -- Dmitry