From: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
To: "Tobin C. Harding" <me@tobin.cc>
Cc: Jonathan Corbet <corbet@lwn.net>,
Josh Triplett <josh@joshtriplett.org>,
Linux docs <linux-doc@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [RFC] doc: fix code snippet build warnings
Date: Wed, 10 Jan 2018 13:08:16 -0800 [thread overview]
Message-ID: <20180110210816.GN9671@linux.vnet.ibm.com> (raw)
In-Reply-To: <20180110203007.GB25272@eros>
On Thu, Jan 11, 2018 at 07:30:07AM +1100, Tobin C. Harding wrote:
> On Wed, Jan 10, 2018 at 08:37:02AM -0800, Paul E. McKenney wrote:
> > On Wed, Jan 10, 2018 at 03:04:53PM +1100, Tobin C. Harding wrote:
> > > Posting as RFC in the hope that someone knows how to massage sphinx
> > > correctly to fix this patch.
> >
> > I would welcome that. ;-)
> >
> > > Currently function kernel-doc contains a multi-line code snippet. This
> > > is causing sphinx to emit 5 build warnings
> > >
> > > WARNING: Unexpected indentation.
> > > WARNING: Unexpected indentation.
> > > WARNING: Block quote ends without a blank line; unexpected unindent.
> > > WARNING: Block quote ends without a blank line; unexpected unindent.
> > > WARNING: Inline literal start-string without end-string.
> > >
> > > And the snippet is not rendering correctly in HTML.
> > >
> > > We can stop shpinx complaining by using '::' instead of the currently
> > > used '``' however this still does not render correctly in HTML. The
> > > rendering is [arguably] better but still incorrect. Sphinx renders two
> > > function calls thus:
> > >
> > > :c:func:`rcu_read_lock()`;
> > >
> > > The rest of the snippet does however have correct spacing.
> > >
> > > Use '::' to pre-fix code snippet. Clears build warnings but does not
> > > render correctly.
> >
> > If the usual docbook suspects ack this, I would be happy to carry it.
> >
> > Cue debate over silent vs. noisy errors. ;-)
>
> Besides making me laugh out loud I did not think of this issue while
> patching. FWIW, now you have mentioned it, I favour noisy errors :)
Very good, will leave this one alone, then. ;-)
Thanx, Paul
next prev parent reply other threads:[~2018-01-10 21:07 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-10 4:04 [RFC] doc: fix code snippet build warnings Tobin C. Harding
2018-01-10 16:37 ` Paul E. McKenney
2018-01-10 20:30 ` Tobin C. Harding
2018-01-10 21:08 ` Paul E. McKenney [this message]
2018-01-10 21:59 ` Jonathan Corbet
2018-01-10 22:25 ` Tobin C. Harding
2018-01-10 22:26 ` Tobin C. Harding
2018-01-16 10:26 ` Jani Nikula
2018-01-16 10:22 ` Jani Nikula
2018-01-16 12:36 ` Markus Heiser
2018-01-16 13:14 ` Jani Nikula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180110210816.GN9671@linux.vnet.ibm.com \
--to=paulmck@linux.vnet.ibm.com \
--cc=corbet@lwn.net \
--cc=josh@joshtriplett.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=me@tobin.cc \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox