From: Stephen Boyd <sboyd@codeaurora.org>
To: Geert Uytterhoeven <geert+renesas@glider.be>
Cc: Michael Turquette <mturquette@baylibre.com>,
linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 4/4] clk: Fix debugfs_create_*() usage
Date: Wed, 10 Jan 2018 13:14:07 -0800 [thread overview]
Message-ID: <20180110211407.GK21040@codeaurora.org> (raw)
In-Reply-To: <1514977577-11854-5-git-send-email-geert+renesas@glider.be>
On 01/03, Geert Uytterhoeven wrote:
> When exposing data access through debugfs, the correct
> debugfs_create_*() functions must be used, matching the data types.
>
> Remove all casts from data pointers passed to debugfs_create_*()
> functions, as such casts prevent the compiler from flagging bugs.
>
> clk_core.rate and .accuracy are "unsigned long", hence casting their
> addresses to "u32 *" exposed the wrong halves on big-endian 64-bit
> systems. Fix this by using debugfs_create_ulong() instead.
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
Applied to clk-next
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
prev parent reply other threads:[~2018-01-10 21:14 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-03 11:06 [PATCH v2 0/4] clk: Fix debugfs_create_*() usage Geert Uytterhoeven
2018-01-03 11:06 ` [PATCH v2 1/4] clk: Improve flags doc for of_clk_detect_critical() Geert Uytterhoeven
2018-01-10 21:14 ` Stephen Boyd
2018-01-03 11:06 ` [PATCH v2 2/4] clk: Use octal instead of symbolic permissions Geert Uytterhoeven
2018-01-10 21:14 ` Stephen Boyd
2018-01-03 11:06 ` [PATCH v2 3/4] clk: Show symbolic clock flags in debugfs Geert Uytterhoeven
2018-01-10 2:02 ` Stephen Boyd
2018-01-10 7:53 ` Geert Uytterhoeven
2018-01-10 21:14 ` Stephen Boyd
2018-01-03 11:06 ` [PATCH v2 4/4] clk: Fix debugfs_create_*() usage Geert Uytterhoeven
2018-01-10 21:14 ` Stephen Boyd [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180110211407.GK21040@codeaurora.org \
--to=sboyd@codeaurora.org \
--cc=geert+renesas@glider.be \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).