From: Tejun Heo <tj@kernel.org>
To: "Michael Kerrisk (man-pages)" <mtk.manpages@gmail.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
cgroups@vger.kernel.org, lkml <linux-kernel@vger.kernel.org>,
linux-man <linux-man@vger.kernel.org>,
"Serge E. Hallyn" <serge@hallyn.com>,
Mike Galbraith <efault@gmx.de>, Li Zefan <lizefan@huawei.com>,
Ingo Molnar <mingo@redhat.com>, Paul Turner <pjt@google.com>,
kernel-team@fb.com, Andy Lutomirski <luto@amacapital.net>,
Johannes Weiner <hannes@cmpxchg.org>,
Lauro Venancio <lvenanci@redhat.com>,
Waiman Long <longman@redhat.com>
Subject: Re: cgroups(7): documenting cgroups v2 thread mode
Date: Wed, 10 Jan 2018 14:29:13 -0800 [thread overview]
Message-ID: <20180110222913.GH3460072@devbig577.frc2.facebook.com> (raw)
In-Reply-To: <704d0cd5-0bab-f876-a09c-9d60e9d2ef93@gmail.com>
Hello,
On Wed, Jan 10, 2018 at 11:18:48PM +0100, Michael Kerrisk (man-pages) wrote:
> Ahh yes. Now I understand. I made the description of the containment
> rules for cgroup.threads more explicit in the text:
>
> As with writing to cgroup.procs, some containment rules apply when
> writing to the cgroup.threads file:
>
> * The writer must have write permission on the cgroup.threads
> file in the destination cgroup.
>
> * The writer must have write permission on the cgroup.procs file
> in the common ancestor of the source and destination cgroups.
> (In some cases, the common ancestor may be the source or desti‐
> nation cgroup itself.)
>
> * The source and destination cgroups must be in the same threaded
> subtree. (Outside a threaded subtree, an attempt to move a
> thread by writing its thread ID to the cgroup.threads in a dif‐
> ferent domain cgroup fails with the error EOPNOTSUPP.)
>
> Okay? (I realize that the last bullet point is a rather different way of
> formulating your idea that "the only extra restriction is that the domain
> cgroup must be the same for the source and destination". But I think the
> reformulation is easier to understand, no?)
It looks great to me. Me explaining that way is mostly from internal
/ conceptual POV. Yours is definitely more approachable.
Thanks.
--
tejun
prev parent reply other threads:[~2018-01-10 22:29 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-02 18:24 cgroups(7): documenting cgroups v2 thread mode Michael Kerrisk (man-pages)
2018-01-09 21:10 ` Tejun Heo
2018-01-09 22:52 ` Michael Kerrisk (man-pages)
2018-01-09 22:54 ` Michael Kerrisk (man-pages)
2018-01-10 14:47 ` Tejun Heo
2018-01-10 22:18 ` Michael Kerrisk (man-pages)
2018-01-10 22:29 ` Tejun Heo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180110222913.GH3460072@devbig577.frc2.facebook.com \
--to=tj@kernel.org \
--cc=cgroups@vger.kernel.org \
--cc=efault@gmx.de \
--cc=hannes@cmpxchg.org \
--cc=kernel-team@fb.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-man@vger.kernel.org \
--cc=lizefan@huawei.com \
--cc=longman@redhat.com \
--cc=luto@amacapital.net \
--cc=lvenanci@redhat.com \
--cc=mingo@redhat.com \
--cc=mtk.manpages@gmail.com \
--cc=peterz@infradead.org \
--cc=pjt@google.com \
--cc=serge@hallyn.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox