From mboxrd@z Thu Jan 1 00:00:00 1970 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752893AbeAKBL1 (ORCPT + 1 other); Wed, 10 Jan 2018 20:11:27 -0500 Received: from out3-smtp.messagingengine.com ([66.111.4.27]:56687 "EHLO out3-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752312AbeAKBL0 (ORCPT ); Wed, 10 Jan 2018 20:11:26 -0500 X-ME-Sender: Date: Thu, 11 Jan 2018 12:11:22 +1100 From: "Tobin C. Harding" To: Jonny Schaefer Cc: Greg Kroah-Hartman , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, linux-kernel@i4.cs.fau.de Subject: Re: [PATCH v2] drivers/fbtft: Fix indentation Message-ID: <20180111011122.GC23786@eros> References: <20180108145620.GA22613@kroah.com> <1515605435-26783-1-git-send-email-schaefer.jonny@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1515605435-26783-1-git-send-email-schaefer.jonny@gmail.com> X-Mailer: Mutt 1.5.24 (2015-08-30) User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: On Wed, Jan 10, 2018 at 06:30:35PM +0100, Jonny Schaefer wrote: > From: Luis Gerhorst > > This fixes the checkpatch message: > > CHECK: Alignment should match open parenthesis > #1380: FILE: drivers/staging/fbtft/fbtft-core.c:1380: > + dev_warn(dev, > + "no default functions for regwidth=%d and buswidth=%d\n", > Perhaps: Checkpatch emits CHECK: Alignment should match open parenthesis Align code to open parenthesis. Reasoning: Patch description should describe the problem then describe what the patch does (in imperative mood). Better advice is given in Documentation/process/submitting-patches.rst section 2 Hope this helps, Tobin.