* [PATCH] tools/testing: Fix trailing semicolon
@ 2018-01-11 13:46 Luis de Bethencourt
2018-01-11 17:21 ` Shuah Khan
0 siblings, 1 reply; 3+ messages in thread
From: Luis de Bethencourt @ 2018-01-11 13:46 UTC (permalink / raw)
To: linux-kernel
Cc: linux-kselftest, Shuah Khan, Greg Kroah-Hartman, Thomas Gleixner,
Kate Stewart, Joe Perches, Luis de Bethencourt
The trailing semicolon is an empty statement that does no operation.
Removing it since it doesn't do anything.
Signed-off-by: Luis de Bethencourt <luisbg@kernel.org>
---
Hi Shuah,
After fixing the same thing in drivers/staging/rtl8723bs/, Joe Perches
suggested I fix it treewide [0].
Best regards :)
Luis
[0] http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2018-January/115410.html
[1] http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2018-January/115390.html
tools/testing/selftests/nsfs/pidns.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/testing/selftests/nsfs/pidns.c b/tools/testing/selftests/nsfs/pidns.c
index 1182d4e437a2..e0d86e1668c0 100644
--- a/tools/testing/selftests/nsfs/pidns.c
+++ b/tools/testing/selftests/nsfs/pidns.c
@@ -70,7 +70,7 @@ int main(int argc, char *argv[])
return pr_err("NS_GET_PARENT returned a wrong namespace");
if (ioctl(pns, NS_GET_PARENT) >= 0 || errno != EPERM)
- return pr_err("Don't get EPERM");;
+ return pr_err("Don't get EPERM");
}
kill(pid, SIGKILL);
--
2.15.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] tools/testing: Fix trailing semicolon
2018-01-11 13:46 [PATCH] tools/testing: Fix trailing semicolon Luis de Bethencourt
@ 2018-01-11 17:21 ` Shuah Khan
2018-01-11 18:03 ` Luis de Bethencourt
0 siblings, 1 reply; 3+ messages in thread
From: Shuah Khan @ 2018-01-11 17:21 UTC (permalink / raw)
To: Luis de Bethencourt, linux-kernel
Cc: linux-kselftest, Greg Kroah-Hartman, Thomas Gleixner,
Kate Stewart, Joe Perches, Shuah Khan, Shuah Khan
On 01/11/2018 06:46 AM, Luis de Bethencourt wrote:
> The trailing semicolon is an empty statement that does no operation.
> Removing it since it doesn't do anything.
>
> Signed-off-by: Luis de Bethencourt <luisbg@kernel.org>
> ---
>
> Hi Shuah,
>
> After fixing the same thing in drivers/staging/rtl8723bs/, Joe Perches
> suggested I fix it treewide [0].
>
> Best regards :)
> Luis
>
>
> [0] http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2018-January/115410.html
> [1] http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2018-January/115390.html
>
> tools/testing/selftests/nsfs/pidns.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/nsfs/pidns.c b/tools/testing/selftests/nsfs/pidns.c
> index 1182d4e437a2..e0d86e1668c0 100644
> --- a/tools/testing/selftests/nsfs/pidns.c
> +++ b/tools/testing/selftests/nsfs/pidns.c
> @@ -70,7 +70,7 @@ int main(int argc, char *argv[])
> return pr_err("NS_GET_PARENT returned a wrong namespace");
>
> if (ioctl(pns, NS_GET_PARENT) >= 0 || errno != EPERM)
> - return pr_err("Don't get EPERM");;
> + return pr_err("Don't get EPERM");
> }
>
> kill(pid, SIGKILL);
>
Thanks for the patch. I will take this in for 4.16-rc1.
thanks,
-- Shuah
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] tools/testing: Fix trailing semicolon
2018-01-11 17:21 ` Shuah Khan
@ 2018-01-11 18:03 ` Luis de Bethencourt
0 siblings, 0 replies; 3+ messages in thread
From: Luis de Bethencourt @ 2018-01-11 18:03 UTC (permalink / raw)
To: shuah, linux-kernel
Cc: linux-kselftest, Greg Kroah-Hartman, Thomas Gleixner,
Kate Stewart, Joe Perches, Shuah Khan
On 01/11/2018 05:21 PM, Shuah Khan wrote:
> On 01/11/2018 06:46 AM, Luis de Bethencourt wrote:
>> The trailing semicolon is an empty statement that does no operation.
>> Removing it since it doesn't do anything.
>>
>> Signed-off-by: Luis de Bethencourt <luisbg@kernel.org>
>> ---
>>
>> Hi Shuah,
>>
>> After fixing the same thing in drivers/staging/rtl8723bs/, Joe Perches
>> suggested I fix it treewide [0].
>>
>> Best regards :)
>> Luis
>>
>>
>> [0] http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2018-January/115410.html
>> [1] http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2018-January/115390.html
>>
>> tools/testing/selftests/nsfs/pidns.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/tools/testing/selftests/nsfs/pidns.c b/tools/testing/selftests/nsfs/pidns.c
>> index 1182d4e437a2..e0d86e1668c0 100644
>> --- a/tools/testing/selftests/nsfs/pidns.c
>> +++ b/tools/testing/selftests/nsfs/pidns.c
>> @@ -70,7 +70,7 @@ int main(int argc, char *argv[])
>> return pr_err("NS_GET_PARENT returned a wrong namespace");
>>
>> if (ioctl(pns, NS_GET_PARENT) >= 0 || errno != EPERM)
>> - return pr_err("Don't get EPERM");;
>> + return pr_err("Don't get EPERM");
>> }
>>
>> kill(pid, SIGKILL);
>>
>
> Thanks for the patch. I will take this in for 4.16-rc1.
>
> thanks,
> -- Shuah
>
Awesome. Thanks Shuah!
Luis
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-01-11 18:03 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-01-11 13:46 [PATCH] tools/testing: Fix trailing semicolon Luis de Bethencourt
2018-01-11 17:21 ` Shuah Khan
2018-01-11 18:03 ` Luis de Bethencourt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox