From: Jesper Nilsson <jesper.nilsson@axis.com>
To: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
Cc: Mikael Starvik <starvik@axis.com>,
Jesper Nilsson <jespern@axis.com>,
Fenghua Yu <fenghua.yu@intel.com>,
linux-cris-kernel@axis.com, linux-kernel@vger.kernel.org,
Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
Subject: Re: [PATCH] cris: Fix conflicting types for _etext, _edata, _end
Date: Thu, 11 Jan 2018 15:24:23 +0100 [thread overview]
Message-ID: <20180111142423.GA32368@axis.com> (raw)
In-Reply-To: <20180111141251.GA754@tigerII.localdomain>
On Thu, Jan 11, 2018 at 11:12:51PM +0900, Sergey Senozhatsky wrote:
> On (01/05/18 11:47), Sergey Senozhatsky wrote:
> > Include asm/sections.h header which contains the correct
> > types for _etext, _edata and _end - char arrays.
> >
> > Signed-off-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
>
> Mikael, Jesper,
>
> any opinions?
This looks sane, and I can take it in the CRIS tree,
allthough I'm currently pondering the future of the CRIS port,
lack of time and active hardware are increasing problems.
> -ss
/Jesper
> > ---
> > arch/cris/kernel/setup.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/arch/cris/kernel/setup.c b/arch/cris/kernel/setup.c
> > index 524d47501a23..1b61a7207afb 100644
> > --- a/arch/cris/kernel/setup.c
> > +++ b/arch/cris/kernel/setup.c
> > @@ -24,6 +24,7 @@
> > #include <linux/of_fdt.h>
> > #include <asm/setup.h>
> > #include <arch/system.h>
> > +#include <asm/sections.h>
> >
> > /*
> > * Setup options
> > @@ -31,7 +32,6 @@
> > struct screen_info screen_info;
> >
> > extern int root_mountflags;
> > -extern char _etext, _edata, _end;
> >
> > char __initdata cris_command_line[COMMAND_LINE_SIZE] = { 0, };
> >
> > --
> > 2.15.1
> >
/^JN - Jesper Nilsson
--
Jesper Nilsson -- jesper.nilsson@axis.com
next prev parent reply other threads:[~2018-01-11 14:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-05 2:47 [PATCH] cris: Fix conflicting types for _etext, _edata, _end Sergey Senozhatsky
2018-01-11 14:12 ` Sergey Senozhatsky
2018-01-11 14:24 ` Jesper Nilsson [this message]
2018-01-12 1:34 ` Sergey Senozhatsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180111142423.GA32368@axis.com \
--to=jesper.nilsson@axis.com \
--cc=fenghua.yu@intel.com \
--cc=jespern@axis.com \
--cc=linux-cris-kernel@axis.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sergey.senozhatsky.work@gmail.com \
--cc=sergey.senozhatsky@gmail.com \
--cc=starvik@axis.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox