From: Jiri Olsa <jolsa@redhat.com>
To: kan.liang@intel.com
Cc: acme@kernel.org, peterz@infradead.org, mingo@redhat.com,
linux-kernel@vger.kernel.org, wangnan0@huawei.com,
jolsa@kernel.org, namhyung@kernel.org, ak@linux.intel.com,
yao.jin@linux.intel.com
Subject: Re: [PATCH V3 11/12] perf top: switch default mode to overwrite mode
Date: Thu, 11 Jan 2018 15:26:08 +0100 [thread overview]
Message-ID: <20180111142608.GF16655@krava> (raw)
In-Reply-To: <1513879734-237492-12-git-send-email-kan.liang@intel.com>
On Thu, Dec 21, 2017 at 10:08:53AM -0800, kan.liang@intel.com wrote:
SNIP
> .max_stack = sysctl_perf_event_max_stack,
> .sym_pcnt_filter = 5,
> diff --git a/tools/perf/ui/browsers/hists.c b/tools/perf/ui/browsers/hists.c
> index 68146f4..56023e4 100644
> --- a/tools/perf/ui/browsers/hists.c
> +++ b/tools/perf/ui/browsers/hists.c
> @@ -638,8 +638,13 @@ int hist_browser__run(struct hist_browser *browser, const char *help)
> nr_entries = hist_browser__nr_entries(browser);
> ui_browser__update_nr_entries(&browser->b, nr_entries);
>
> - if (browser->hists->stats.nr_lost_warned !=
> - browser->hists->stats.nr_events[PERF_RECORD_LOST]) {
> + /*
> + * Don't print lost events warning for perf top,
> + * because it is overwrite mode.
> + * Perf top is the only tool which has hbt timer.
> + */
I hate that warning, but still should it be ommited only for overwrite case?
also please separate this change from the rest of the patch
jirka
> + if ((browser->hists->stats.nr_lost_warned !=
> + browser->hists->stats.nr_events[PERF_RECORD_LOST]) && !hbt) {
> browser->hists->stats.nr_lost_warned =
> browser->hists->stats.nr_events[PERF_RECORD_LOST];
> ui_browser__warn_lost_events(&browser->b);
> @@ -3203,7 +3208,8 @@ static int perf_evsel_menu__run(struct perf_evsel_menu *menu,
> case K_TIMER:
> hbt->timer(hbt->arg);
>
> - if (!menu->lost_events_warned && menu->lost_events) {
> + if (!menu->lost_events_warned &&
> + menu->lost_events && !hbt) {
> ui_browser__warn_lost_events(&menu->b);
> menu->lost_events_warned = true;
> }
> --
> 2.5.5
>
next prev parent reply other threads:[~2018-01-11 14:26 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-21 18:08 [PATCH V3 00/12] perf top overwrite mode kan.liang
2017-12-21 18:08 ` [PATCH V3 01/12] perf evlist: remove stale mmap read for backward kan.liang
2017-12-21 18:08 ` [PATCH V3 02/12] perf mmap: factor out function to find ringbuffer position kan.liang
2018-01-10 15:37 ` Jiri Olsa
2018-01-10 19:31 ` Liang, Kan
2018-01-11 14:25 ` Jiri Olsa
2018-01-11 21:26 ` Liang, Kan
2018-01-12 10:52 ` Jiri Olsa
2017-12-21 18:08 ` [PATCH V3 03/12] perf mmap: discard 'prev' in perf_mmap__read kan.liang
2018-01-11 14:25 ` Jiri Olsa
2018-01-11 21:27 ` Liang, Kan
2017-12-21 18:08 ` [PATCH V3 04/12] perf mmap: introduce perf_mmap__read_done kan.liang
2018-01-02 7:33 ` Namhyung Kim
2018-01-03 14:15 ` Liang, Kan
2018-01-04 2:46 ` Namhyung Kim
2018-01-04 14:00 ` Liang, Kan
2018-01-09 7:12 ` Namhyung Kim
2018-01-09 15:12 ` Liang, Kan
2018-01-11 12:00 ` Namhyung Kim
2018-01-11 14:40 ` Liang, Kan
2018-01-11 14:25 ` Jiri Olsa
2018-01-11 21:27 ` Liang, Kan
2017-12-21 18:08 ` [PATCH V3 05/12] perf mmap: introduce perf_mmap__read_event kan.liang
2017-12-21 18:08 ` [PATCH V3 06/12] perf test: update mmap read functions for backward-ring-buffer test kan.liang
2017-12-21 18:08 ` [PATCH V3 07/12] perf mmap: discard legacy interface for mmap read kan.liang
2018-01-11 14:25 ` Jiri Olsa
2018-01-11 21:28 ` Liang, Kan
2018-01-12 10:52 ` Jiri Olsa
2017-12-21 18:08 ` [PATCH V3 08/12] perf top: check per event overwrite term kan.liang
2018-01-11 14:25 ` Jiri Olsa
2018-01-11 21:29 ` Liang, Kan
2018-01-12 11:42 ` Jiri Olsa
2018-01-12 14:58 ` Liang, Kan
2018-01-12 16:46 ` Liang, Kan
2017-12-21 18:08 ` [PATCH V3 09/12] perf evsel: expose perf_missing_features.write_backward kan.liang
2017-12-21 18:08 ` [PATCH V3 10/12] perf top: add overwrite fall back kan.liang
2018-01-11 14:26 ` Jiri Olsa
2018-01-11 21:30 ` Liang, Kan
2018-01-12 11:42 ` Jiri Olsa
2017-12-21 18:08 ` [PATCH V3 11/12] perf top: switch default mode to overwrite mode kan.liang
2018-01-11 14:26 ` Jiri Olsa [this message]
2018-01-11 21:30 ` Liang, Kan
2018-01-11 21:30 ` Liang, Kan
2018-01-11 14:26 ` Jiri Olsa
2017-12-21 18:08 ` [PATCH V3 12/12] perf top: check the latency of perf_top__mmap_read kan.liang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180111142608.GF16655@krava \
--to=jolsa@redhat.com \
--cc=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=jolsa@kernel.org \
--cc=kan.liang@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=wangnan0@huawei.com \
--cc=yao.jin@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox