From mboxrd@z Thu Jan 1 00:00:00 1970 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934480AbeAKOv0 (ORCPT + 1 other); Thu, 11 Jan 2018 09:51:26 -0500 Received: from mx1.redhat.com ([209.132.183.28]:39880 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933026AbeAKOvZ (ORCPT ); Thu, 11 Jan 2018 09:51:25 -0500 Date: Thu, 11 Jan 2018 15:51:19 +0100 From: Jiri Olsa To: Mathieu Poirier Cc: acme@kernel.org, ak@linux.intel.com, peterz@infradead.org, mingo@redhat.com, alexander.shishkin@linux.intel.com, namhyung@kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] perf evsel: Fix incorrect handling of type _TERM_DRV_CFG Message-ID: <20180111145119.GA20406@krava> References: <1515617211-32024-1-git-send-email-mathieu.poirier@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1515617211-32024-1-git-send-email-mathieu.poirier@linaro.org> User-Agent: Mutt/1.9.1 (2017-09-22) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.31]); Thu, 11 Jan 2018 14:51:24 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: On Wed, Jan 10, 2018 at 01:46:51PM -0700, Mathieu Poirier wrote: > Commit ("d0565132605f perf evsel: Enable type checking for > perf_evsel_config_term types") assumes PERF_EVSEL__CONFIG_TERM_DRV_CFG > isn't used and as such adds a BUG_ON(). > > Since the enumeration type is used in macro ADD_CONFIG_TERM() the change > break CoreSight trace acquisition. > > This patch restores the original code. > > Signed-off-by: Mathieu Poirier Acked-by: Jiri Olsa thanks, jirka > --- > tools/perf/util/evsel.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/perf/util/evsel.c b/tools/perf/util/evsel.c > index a4d256ea0dc4..b22071a20cd1 100644 > --- a/tools/perf/util/evsel.c > +++ b/tools/perf/util/evsel.c > @@ -781,7 +781,7 @@ static void apply_config_terms(struct perf_evsel *evsel, > attr->write_backward = term->val.overwrite ? 1 : 0; > break; > case PERF_EVSEL__CONFIG_TERM_DRV_CFG: > - BUG_ON(1); > + break; > default: > break; > } > -- > 2.7.4 >