From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Jiri Olsa <jolsa@redhat.com>
Cc: Mathieu Poirier <mathieu.poirier@linaro.org>,
ak@linux.intel.com, peterz@infradead.org, mingo@redhat.com,
alexander.shishkin@linux.intel.com, namhyung@kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] perf evsel: Fix incorrect handling of type _TERM_DRV_CFG
Date: Thu, 11 Jan 2018 11:58:20 -0300 [thread overview]
Message-ID: <20180111145820.GA3025@kernel.org> (raw)
In-Reply-To: <20180111145119.GA20406@krava>
Em Thu, Jan 11, 2018 at 03:51:19PM +0100, Jiri Olsa escreveu:
> On Wed, Jan 10, 2018 at 01:46:51PM -0700, Mathieu Poirier wrote:
> > Commit ("d0565132605f perf evsel: Enable type checking for
> > perf_evsel_config_term types") assumes PERF_EVSEL__CONFIG_TERM_DRV_CFG
> > isn't used and as such adds a BUG_ON().
> >
> > Since the enumeration type is used in macro ADD_CONFIG_TERM() the change
> > break CoreSight trace acquisition.
> >
> > This patch restores the original code.
> >
> > Signed-off-by: Mathieu Poirier <mathieu.poirier@linaro.org>
>
> Acked-by: Jiri Olsa <jolsa@kernel.org>
Thanks, applied, and this affects only perf/core,
- Arnaldo
next prev parent reply other threads:[~2018-01-11 14:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-10 20:46 [PATCH] perf evsel: Fix incorrect handling of type _TERM_DRV_CFG Mathieu Poirier
2018-01-11 14:51 ` Jiri Olsa
2018-01-11 14:58 ` Arnaldo Carvalho de Melo [this message]
2018-01-17 16:25 ` [tip:perf/core] " tip-bot for Mathieu Poirier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180111145820.GA3025@kernel.org \
--to=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox