From mboxrd@z Thu Jan 1 00:00:00 1970 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933854AbeAKO6Y (ORCPT + 1 other); Thu, 11 Jan 2018 09:58:24 -0500 Received: from mail.kernel.org ([198.145.29.99]:59564 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932458AbeAKO6X (ORCPT ); Thu, 11 Jan 2018 09:58:23 -0500 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7CC3A2173D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=acme@kernel.org Date: Thu, 11 Jan 2018 11:58:20 -0300 From: Arnaldo Carvalho de Melo To: Jiri Olsa Cc: Mathieu Poirier , ak@linux.intel.com, peterz@infradead.org, mingo@redhat.com, alexander.shishkin@linux.intel.com, namhyung@kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] perf evsel: Fix incorrect handling of type _TERM_DRV_CFG Message-ID: <20180111145820.GA3025@kernel.org> References: <1515617211-32024-1-git-send-email-mathieu.poirier@linaro.org> <20180111145119.GA20406@krava> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180111145119.GA20406@krava> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.9.1 (2017-09-22) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: Em Thu, Jan 11, 2018 at 03:51:19PM +0100, Jiri Olsa escreveu: > On Wed, Jan 10, 2018 at 01:46:51PM -0700, Mathieu Poirier wrote: > > Commit ("d0565132605f perf evsel: Enable type checking for > > perf_evsel_config_term types") assumes PERF_EVSEL__CONFIG_TERM_DRV_CFG > > isn't used and as such adds a BUG_ON(). > > > > Since the enumeration type is used in macro ADD_CONFIG_TERM() the change > > break CoreSight trace acquisition. > > > > This patch restores the original code. > > > > Signed-off-by: Mathieu Poirier > > Acked-by: Jiri Olsa Thanks, applied, and this affects only perf/core, - Arnaldo