From: Mark Brown <broonie@kernel.org>
To: fischerc@swissphone.de
Cc: alsa-devel@alsa-project.org, lgirdwood@gmail.com, perex@perex.cz,
tiwai@suse.com, richard.leitner@skidata.com,
fabio.estevam@nxp.com, bhumirks@gmail.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ASoC: sgtl5000: fix powerup/down of micbias-voltage
Date: Thu, 11 Jan 2018 15:07:04 +0000 [thread overview]
Message-ID: <20180111150704.GC7834@sirena.org.uk> (raw)
In-Reply-To: <1515660031-9183-1-git-send-email-fischerc@swissphone.de>
[-- Attachment #1: Type: text/plain, Size: 537 bytes --]
On Thu, Jan 11, 2018 at 09:40:31AM +0100, fischerc@swissphone.de wrote:
> The mic-bias-voltage should get powered up/down automatically.
> Added missing DAPM_PRE and DAPM_POST widgets to fire up the mic_bias_event function.
> + SND_SOC_DAPM_PRE("MIC_BIAS_PRE", mic_bias_event),
> + SND_SOC_DAPM_POST("MIC_BIAS_POST", mic_bias_event),
I don't understand what this is intended to do. The mic_bias_event()
callback is already hooked up to the Mic Bias supply widget, it should
be invoked whenever the bias is turned on and off already?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2018-01-11 15:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-11 8:40 [PATCH] ASoC: sgtl5000: fix powerup/down of micbias-voltage fischerc
2018-01-11 15:07 ` Mark Brown [this message]
2018-01-11 16:14 ` AW: " Fischer, Christian
2018-01-11 16:19 ` Mark Brown
-- strict thread matches above, loose matches on Subject: below --
2018-01-12 12:35 Fischer, Christian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180111150704.GC7834@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=bhumirks@gmail.com \
--cc=fabio.estevam@nxp.com \
--cc=fischerc@swissphone.de \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=richard.leitner@skidata.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox