From mboxrd@z Thu Jan 1 00:00:00 1970 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934625AbeAKPHW (ORCPT + 1 other); Thu, 11 Jan 2018 10:07:22 -0500 Received: from heliosphere.sirena.org.uk ([172.104.155.198]:57094 "EHLO heliosphere.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933305AbeAKPHU (ORCPT ); Thu, 11 Jan 2018 10:07:20 -0500 Date: Thu, 11 Jan 2018 15:07:04 +0000 From: Mark Brown To: fischerc@swissphone.de Cc: alsa-devel@alsa-project.org, lgirdwood@gmail.com, perex@perex.cz, tiwai@suse.com, richard.leitner@skidata.com, fabio.estevam@nxp.com, bhumirks@gmail.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ASoC: sgtl5000: fix powerup/down of micbias-voltage Message-ID: <20180111150704.GC7834@sirena.org.uk> References: <1515660031-9183-1-git-send-email-fischerc@swissphone.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="NKoe5XOeduwbEQHU" Content-Disposition: inline In-Reply-To: <1515660031-9183-1-git-send-email-fischerc@swissphone.de> X-Cookie: I can't drive 55. User-Agent: Mutt/1.9.2 (2017-12-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: --NKoe5XOeduwbEQHU Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Jan 11, 2018 at 09:40:31AM +0100, fischerc@swissphone.de wrote: > The mic-bias-voltage should get powered up/down automatically. > Added missing DAPM_PRE and DAPM_POST widgets to fire up the mic_bias_event function. > + SND_SOC_DAPM_PRE("MIC_BIAS_PRE", mic_bias_event), > + SND_SOC_DAPM_POST("MIC_BIAS_POST", mic_bias_event), I don't understand what this is intended to do. The mic_bias_event() callback is already hooked up to the Mic Bias supply widget, it should be invoked whenever the bias is turned on and off already? --NKoe5XOeduwbEQHU Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAlpXfZcACgkQJNaLcl1U h9Baxgf8CCVwLLUieAcXIUSQO3XCzfsLB+nnPQB2N+H+1VUdr5GSKthXzC12uGzQ asizJ7FtY2VC8wWwk1LztUgvIN+woAIx4W5zvWCwI6dHOkI87wwpurN+TbxvVHX0 9naWN1dSXfkcYmjgpZz5qeL/Yhy4UNXepfw5qmZcQpJPq+fMAUHXZOw1L144Q1IA PKYmD32DejubOpND3jRDn/AyNsuTMYzjlkv67bKQeHmq0S9sTogtfI3EgQ8ZDN0C W84ATnoSfL0rtchQiYjVWdkqbBttuLbwI6EXClQaivKTThnptmoKUwO7nNXvHvHv EWNsCbaZrpjjVa8Zh3X/4IcS4lEyyg== =1x1j -----END PGP SIGNATURE----- --NKoe5XOeduwbEQHU--