From: Al Viro <viro@ZenIV.linux.org.uk>
To: Rakesh Pandit <rakesh@tuxera.com>
Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
Jan Kara <jack@suse.cz>
Subject: Re: [PATCH] vfs: remove unused argument in iterate_bdevs
Date: Thu, 11 Jan 2018 15:31:31 +0000 [thread overview]
Message-ID: <20180111153131.GK13338@ZenIV.linux.org.uk> (raw)
In-Reply-To: <20180111140406.GA10714@dhcp-108-107.ws.tuxera.com>
On Thu, Jan 11, 2018 at 04:04:07PM +0200, Rakesh Pandit wrote:
> Signed-off-by: Rakesh Pandit <rakesh@tuxera.com>
> ---
> fs/block_dev.c | 4 ++--
> fs/sync.c | 12 ++++++------
> include/linux/fs.h | 4 ++--
> 3 files changed, 10 insertions(+), 10 deletions(-)
>
> diff --git a/fs/block_dev.c b/fs/block_dev.c
> index 4a181fc..95eba30 100644
> --- a/fs/block_dev.c
> +++ b/fs/block_dev.c
> @@ -2112,7 +2112,7 @@ int __invalidate_device(struct block_device *bdev, bool kill_dirty)
> }
> EXPORT_SYMBOL(__invalidate_device);
>
> -void iterate_bdevs(void (*func)(struct block_device *, void *), void *arg)
> +void iterate_bdevs(void (*func)(struct block_device *))
Sure, after you implement partially applied functions in C, so that we could
do it properly. Until then - NAK.
next prev parent reply other threads:[~2018-01-11 15:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-11 14:04 [PATCH] vfs: remove unused argument in iterate_bdevs Rakesh Pandit
2018-01-11 15:06 ` Jan Kara
2018-01-11 15:18 ` Rakesh Pandit
2018-01-11 15:31 ` Al Viro [this message]
2018-01-14 15:07 ` kbuild test robot
2018-01-14 16:13 ` kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180111153131.GK13338@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rakesh@tuxera.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox