From mboxrd@z Thu Jan 1 00:00:00 1970 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934972AbeAKQdv (ORCPT + 1 other); Thu, 11 Jan 2018 11:33:51 -0500 Received: from mx1.redhat.com ([209.132.183.28]:53654 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933231AbeAKQdu (ORCPT ); Thu, 11 Jan 2018 11:33:50 -0500 Date: Thu, 11 Jan 2018 10:33:26 -0600 From: Josh Poimboeuf To: David Woodhouse Cc: x86@kernel.org, linux-kernel@vger.kernel.org, Thomas Gleixner , Andi Kleen , Paul Turner , Linus Torvalds , Greg Kroah-Hartman , Tim Chen , Dave Hansen , Kees Cook , Peter Zijlstra , Andy Lutomirski , Jiri Kosina , gnomes@lxorguk.ukuu.org.uk Subject: Re: [PATCH 2/3] objtool: Ignore retpoline alternatives Message-ID: <20180111163326.deqtbqt72avfweup@treble> References: <1515688058.22302.366.camel@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1515688058.22302.366.camel@infradead.org> User-Agent: Mutt/1.6.0.1 (2016-04-01) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.32]); Thu, 11 Jan 2018 16:33:50 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: On Thu, Jan 11, 2018 at 04:27:38PM +0000, David Woodhouse wrote: > On Wed, 2018-01-10 at 19:48 -0600, Josh Poimboeuf wrote: > > > > +#define ANNOTATE_NOSPEC_ALTERNATIVE                            \ > > +       "999:\n\t"                                              \ > > +       ".pushsection .discard.nospec\n\t"                      \ > > +       ".long 999b - .\n\t"                                    \ > > +       ".popsection\n\t" > > + > > >   Ick, numbers. Use .Lfoo_%= instead. > I seem to recall that not working with inline asm, maybe old versions of GCC don't like it or something? I can try it and see if 0-day bot complains. -- Josh