From mboxrd@z Thu Jan 1 00:00:00 1970 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965635AbeAKTSS (ORCPT + 1 other); Thu, 11 Jan 2018 14:18:18 -0500 Received: from imap.thunk.org ([74.207.234.97]:37796 "EHLO imap.thunk.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965599AbeAKTSP (ORCPT ); Thu, 11 Jan 2018 14:18:15 -0500 Date: Thu, 11 Jan 2018 14:18:10 -0500 From: Theodore Ts'o To: Jan Kara Cc: Colin King , Andreas Dilger , linux-ext4@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ext4: fix incorrect indentation of if statement Message-ID: <20180111191810.GF19241@thunk.org> Mail-Followup-To: Theodore Ts'o , Jan Kara , Colin King , Andreas Dilger , linux-ext4@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org References: <20171129142059.21898-1-colin.king@canonical.com> <20180104154018.GB2170@quack2.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180104154018.GB2170@quack2.suse.cz> User-Agent: Mutt/1.9.2 (2017-12-15) X-SA-Exim-Connect-IP: X-SA-Exim-Mail-From: tytso@thunk.org X-SA-Exim-Scanned: No (on imap.thunk.org); SAEximRunCond expanded to false Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: On Thu, Jan 04, 2018 at 04:40:18PM +0100, Jan Kara wrote: > On Wed 29-11-17 14:20:59, Colin King wrote: > > From: Colin Ian King > > > > The indentation is incorrect and spaces need replacing with a tab > > on the if statement. > > > > Cleans up smatch warning: > > fs/ext4/namei.c:3220 ext4_link() warn: inconsistent indenting > > > > Signed-off-by: Colin Ian King > > This seems to fall through cracks. The patch looks good. You can add: > > Reviewed-by: Jan Kara Thanks, applied. There was actually another whitespace issue on the following line, which I've fixed up and merged into this patch. - Ted