* [PATCH] ext4: fix incorrect indentation of if statement
@ 2017-11-29 14:20 Colin King
2018-01-04 15:40 ` Jan Kara
0 siblings, 1 reply; 3+ messages in thread
From: Colin King @ 2017-11-29 14:20 UTC (permalink / raw)
To: Theodore Ts'o, Andreas Dilger, linux-ext4
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
The indentation is incorrect and spaces need replacing with a tab
on the if statement.
Cleans up smatch warning:
fs/ext4/namei.c:3220 ext4_link() warn: inconsistent indenting
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
fs/ext4/namei.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/fs/ext4/namei.c b/fs/ext4/namei.c
index 798b3ac680db..d3fabc553c65 100644
--- a/fs/ext4/namei.c
+++ b/fs/ext4/namei.c
@@ -3217,8 +3217,8 @@ static int ext4_link(struct dentry *old_dentry,
if (err)
return err;
- if ((ext4_test_inode_flag(dir, EXT4_INODE_PROJINHERIT)) &&
- (!projid_eq(EXT4_I(dir)->i_projid,
+ if ((ext4_test_inode_flag(dir, EXT4_INODE_PROJINHERIT)) &&
+ (!projid_eq(EXT4_I(dir)->i_projid,
EXT4_I(old_dentry->d_inode)->i_projid)))
return -EXDEV;
--
2.14.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] ext4: fix incorrect indentation of if statement
2017-11-29 14:20 [PATCH] ext4: fix incorrect indentation of if statement Colin King
@ 2018-01-04 15:40 ` Jan Kara
2018-01-11 19:18 ` Theodore Ts'o
0 siblings, 1 reply; 3+ messages in thread
From: Jan Kara @ 2018-01-04 15:40 UTC (permalink / raw)
To: Colin King
Cc: Theodore Ts'o, Andreas Dilger, linux-ext4, kernel-janitors,
linux-kernel
On Wed 29-11-17 14:20:59, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The indentation is incorrect and spaces need replacing with a tab
> on the if statement.
>
> Cleans up smatch warning:
> fs/ext4/namei.c:3220 ext4_link() warn: inconsistent indenting
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
This seems to fall through cracks. The patch looks good. You can add:
Reviewed-by: Jan Kara <jack@suse.cz>
Honza
> ---
> fs/ext4/namei.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/fs/ext4/namei.c b/fs/ext4/namei.c
> index 798b3ac680db..d3fabc553c65 100644
> --- a/fs/ext4/namei.c
> +++ b/fs/ext4/namei.c
> @@ -3217,8 +3217,8 @@ static int ext4_link(struct dentry *old_dentry,
> if (err)
> return err;
>
> - if ((ext4_test_inode_flag(dir, EXT4_INODE_PROJINHERIT)) &&
> - (!projid_eq(EXT4_I(dir)->i_projid,
> + if ((ext4_test_inode_flag(dir, EXT4_INODE_PROJINHERIT)) &&
> + (!projid_eq(EXT4_I(dir)->i_projid,
> EXT4_I(old_dentry->d_inode)->i_projid)))
> return -EXDEV;
>
> --
> 2.14.1
>
--
Jan Kara <jack@suse.com>
SUSE Labs, CR
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ext4: fix incorrect indentation of if statement
2018-01-04 15:40 ` Jan Kara
@ 2018-01-11 19:18 ` Theodore Ts'o
0 siblings, 0 replies; 3+ messages in thread
From: Theodore Ts'o @ 2018-01-11 19:18 UTC (permalink / raw)
To: Jan Kara
Cc: Colin King, Andreas Dilger, linux-ext4, kernel-janitors,
linux-kernel
On Thu, Jan 04, 2018 at 04:40:18PM +0100, Jan Kara wrote:
> On Wed 29-11-17 14:20:59, Colin King wrote:
> > From: Colin Ian King <colin.king@canonical.com>
> >
> > The indentation is incorrect and spaces need replacing with a tab
> > on the if statement.
> >
> > Cleans up smatch warning:
> > fs/ext4/namei.c:3220 ext4_link() warn: inconsistent indenting
> >
> > Signed-off-by: Colin Ian King <colin.king@canonical.com>
>
> This seems to fall through cracks. The patch looks good. You can add:
>
> Reviewed-by: Jan Kara <jack@suse.cz>
Thanks, applied. There was actually another whitespace issue on the
following line, which I've fixed up and merged into this patch.
- Ted
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-01-11 19:18 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-11-29 14:20 [PATCH] ext4: fix incorrect indentation of if statement Colin King
2018-01-04 15:40 ` Jan Kara
2018-01-11 19:18 ` Theodore Ts'o
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox