Re: [PATCH 2/3] tracing: make sure the parsed string always terminates with '\0'

Steven Rostedt
2018-01-10T04:10:27Z

On Wed, 10 Jan 2018 11:02:06 +0800
"Du, Changbin" <changbin.du@intel.com> wrote:

> On Tue, Jan 09, 2018 at 06:02:58PM -0500, Steven Rostedt wrote:
> > On Tue, 9 Jan 2018 17:55:47 +0800
> > changbin.du@intel.com wrote:
> >
> > > From: Changbin Du <changbin.du@intel.com>
> > >
> > > The parser parse every string into parser.buffer. And some of the callers
> > > assume that parser.buffer contains a C string. So it is dangerous that the
> > > parser returns a unterminated string. The userspace can leverage this to
> > > attack the kernel.
> >
> > Is this only a bug if we apply your first patch?
> >
> I don't think so. Seems it is there already.
>

OK. I'll have to take a deeper look into this so that I completely
understand the problem and your solution. I'm currently traveling and
may not get to do that this week. Please ping me next week if you don't
hear back from me on this issue.

Thanks!

-- Steve