From mboxrd@z Thu Jan  1 00:00:00 1970
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S933509AbeALJVx (ORCPT <rfc822;ralf@linux-mips.org> + 1 other);
        Fri, 12 Jan 2018 04:21:53 -0500
Received: from mail.linuxfoundation.org ([140.211.169.12]:55470 "EHLO
        mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S933473AbeALJVt (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 12 Jan 2018 04:21:49 -0500
Date: Fri, 12 Jan 2018 10:21:47 +0100
From: Greg KH <gregkh@linuxfoundation.org>
To: Max Schulze <max.schulze@posteo.de>
Cc: johan@kernel.org, linux-usb@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] USB: serial: option: add id for Motorola Solutions
 TETRA PEI
Message-ID: <20180112092147.GA15093@kroah.com>
References: <20180112082715.5451-1-max.schulze@posteo.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20180112082715.5451-1-max.schulze@posteo.de>
User-Agent: Mutt/1.9.2 (2017-12-15)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>

On Fri, Jan 12, 2018 at 09:27:15AM +0100, Max Schulze wrote:
> Add Motorola Device ID and blacklist entry to the driver usb/serial/option
> 
> Signed-off-by: Max Schulze <max.schulze@posteo.de>
> ---
> v2: reformatted Patch, first version was declined by GK-H's Bot
> 
> Thanks for the help, Johan!
> 
> To an URB setup request from the host
> bmRequestType: 0x21
> bRequest: 34
> wValue: 0x0003
> wIndex: 0 (0x0000)
> wLength: 0
> 
> the device responds with
> URB status: Broken pipe (-EPIPE) (-32)
> 
> So blacklisting to avoid the usb_wwan_send_setup in usb_wwan_dtr_rts of usb_wwan.
> Tested now to work with miniterm.py and minicom without errors.
> 
> D:  Ver= 2.00 Cls=00(>ifc ) Sub=00 Prot=00 MxPS=64 #Cfgs=  1
> P:  Vendor=0cad ProdID=9011 Rev=24.16
> S:  Manufacturer=Motorola Solutions Inc.
> S:  Product=Motorola Solutions TETRA PEI interface
> C:  #Ifs= 2 Cfg#= 1 Atr=80 MxPwr=500mA
> I:  If#= 0 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=00 Prot=00 Driver=(none)
> I:  If#= 1 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=00 Prot=00 Driver=(none)

Why not put all of this information above the --- line?

thanks,

greg k-h