From: Daniel Thompson <daniel.thompson@linaro.org>
To: Enric Balletbo Serra <eballetbo@gmail.com>
Cc: Enric Balletbo i Serra <enric.balletbo@collabora.com>,
Doug Anderson <dianders@google.com>, Pavel Machek <pavel@ucw.cz>,
Rob Herring <robh+dt@kernel.org>,
Jingoo Han <jingoohan1@gmail.com>,
Richard Purdie <rpurdie@rpsys.net>,
Jacek Anaszewski <jacek.anaszewski@gmail.com>,
Brian Norris <briannorris@google.com>,
Guenter Roeck <groeck@google.com>,
Lee Jones <lee.jones@linaro.org>,
Alexandru Stan <amstan@google.com>,
linux-leds@vger.kernel.org,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 3/4] backlight: pwm_bl: compute brightness of LED linearly to human eye.
Date: Fri, 12 Jan 2018 11:50:52 +0000 [thread overview]
Message-ID: <20180112115052.GB3642@birch.example.com> (raw)
In-Reply-To: <CAFqH_50zs+TMZaRNegxYPQOcysvwm9EY5iB8DqNeGYN+QaJP6Q@mail.gmail.com>
On Fri, Jan 12, 2018 at 11:14:54AM +0100, Enric Balletbo Serra wrote:
> > @@ -441,6 +544,26 @@ static int pwm_backlight_probe(struct platform_device *pdev)
> >
> > dev_dbg(&pdev->dev, "got pwm for backlight\n");
> >
> > + if (!data->levels) {
> > + /* Get the PWM period (in nanoseconds) */
> > + pwm_get_state(pb->pwm, &state);
> > +
> > + ret = pwm_backlight_brightness_default(&pdev->dev, data,
> > + state.period);
> > + if (ret < 0) {
> > + dev_err(&pdev->dev,
> > + "failed to setup default brightness table\n");
> > + goto err_alloc;
> > + }
> > + }
> > +
> > + for (i = 0; i <= data->max_brightness; i++)
>
> Oops, horrible and unjustifiable mistake, missing { here :/
Well, at least you found it rather than us :-)
Daniel.
next prev parent reply other threads:[~2018-01-12 11:50 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-10 22:30 [PATCH 0/4] backlight: pwm_bl: support linear interpolation and brightness to human eye Enric Balletbo i Serra
2018-01-10 22:30 ` [PATCH 1/4] backlight: pwm_bl: linear interpolation between brightness-levels Enric Balletbo i Serra
2018-01-10 22:30 ` [PATCH 2/4] dt-bindings: pwm-backlight: add a num-interpolation-steps property Enric Balletbo i Serra
2018-01-19 20:52 ` Rob Herring
2018-01-22 9:16 ` Daniel Thompson
2018-01-23 10:21 ` Enric Balletbo Serra
2018-01-10 22:30 ` [PATCH 3/4] backlight: pwm_bl: compute brightness of LED linearly to human eye Enric Balletbo i Serra
2018-01-12 10:14 ` Enric Balletbo Serra
2018-01-12 11:50 ` Daniel Thompson [this message]
2018-01-10 22:30 ` [PATCH 4/4] dt-bindings: pwm-backlight: move brightness-levels to optional Enric Balletbo i Serra
2018-01-19 20:57 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180112115052.GB3642@birch.example.com \
--to=daniel.thompson@linaro.org \
--cc=amstan@google.com \
--cc=briannorris@google.com \
--cc=devicetree@vger.kernel.org \
--cc=dianders@google.com \
--cc=eballetbo@gmail.com \
--cc=enric.balletbo@collabora.com \
--cc=groeck@google.com \
--cc=jacek.anaszewski@gmail.com \
--cc=jingoohan1@gmail.com \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=robh+dt@kernel.org \
--cc=rpurdie@rpsys.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox