public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@kernel.org>
To: hpa@zytor.com, dvyukov@google.com, tglx@linutronix.de,
	aryabinin@virtuozzo.com, glider@google.com,
	linux-kernel@vger.kernel.org, xiaolong.ye@intel.com
Cc: linux-tip-commits@vger.kernel.org
Subject: Re: [tip:x86/mm] x86/kasan: Panic if there is not enough memory to boot
Date: Sun, 14 Jan 2018 14:07:56 +0100	[thread overview]
Message-ID: <20180114130756.zkysoiwaqfso2ml4@gmail.com> (raw)
In-Reply-To: <tip-74b61d1fb59bed3a6608161b05f2c0f5cb71acf6@git.kernel.org>


* tip-bot for Andrey Ryabinin <tipbot@zytor.com> wrote:

> Commit-ID:  74b61d1fb59bed3a6608161b05f2c0f5cb71acf6
> Gitweb:     https://git.kernel.org/tip/74b61d1fb59bed3a6608161b05f2c0f5cb71acf6
> Author:     Andrey Ryabinin <aryabinin@virtuozzo.com>
> AuthorDate: Wed, 10 Jan 2018 18:36:02 +0300
> Committer:  Thomas Gleixner <tglx@linutronix.de>
> CommitDate: Sun, 14 Jan 2018 12:59:51 +0100
> 
> x86/kasan: Panic if there is not enough memory to boot
> 
> Currently KASAN doesn't panic in case it don't have enough memory
> to boot. Instead, it crashes in some random place:
> 
>  kernel BUG at arch/x86/mm/physaddr.c:27!
> 
>  RIP: 0010:__phys_addr+0x268/0x276
>  Call Trace:
>   kasan_populate_shadow+0x3f2/0x497
>   kasan_init+0x12e/0x2b2
>   setup_arch+0x2825/0x2a2c
>   start_kernel+0xc8/0x15f4
>   x86_64_start_reservations+0x2a/0x2c
>   x86_64_start_kernel+0x72/0x75
>   secondary_startup_64+0xa5/0xb0
> 
> Use memblock_virt_alloc_try_nid() for allocations without failure
> fallback. It will panic with an out of memory message.
> 
> Reported-by: kernel test robot <xiaolong.ye@intel.com>
> Signed-off-by: Andrey Ryabinin <aryabinin@virtuozzo.com>
> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
> Acked-by: Dmitry Vyukov <dvyukov@google.com>
> Cc: kasan-dev@googlegroups.com
> Cc: Alexander Potapenko <glider@google.com>
> Cc: lkp@01.org
> Link: https://lkml.kernel.org/r/20180110153602.18919-1-aryabinin@virtuozzo.com

I think this commit should be in tip:x86/pti for dependency reasons, to get 
backported automatically. I suspect we want the same KASAN robustness in -stable.

If this patch is too high risk and should be in x86/mm, then it should still be 
x86/pti based, to allow later merging into x86/pti.

The latest already-upstream commit of x86/pti is de791821c295, and this commit 
applies cleanly to that base.

Thanks,

	Ingo

  reply	other threads:[~2018-01-14 13:08 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-26  2:03 [lkp-robot] [x86/cpu_entry_area] 10043e02db: kernel_BUG_at_arch/x86/mm/physaddr.c kernel test robot
2017-12-27 18:05 ` Thomas Gleixner
2017-12-27 18:12   ` Dmitry Vyukov
2017-12-28 11:51     ` Thomas Gleixner
2017-12-28 11:54       ` Dmitry Vyukov
2017-12-28 16:18         ` Andrey Ryabinin
2018-01-10  9:36           ` Dmitry Vyukov
2017-12-28 16:01     ` Andrey Ryabinin
2018-01-10 15:36   ` [PATCH] x86/kasan: panic if there is not enough memory to boot Andrey Ryabinin
2018-01-10 15:40     ` Dmitry Vyukov
2018-01-14 12:04     ` [tip:x86/mm] x86/kasan: Panic " tip-bot for Andrey Ryabinin
2018-01-14 13:07       ` Ingo Molnar [this message]
2018-01-14 14:38         ` Thomas Gleixner
2018-01-14 14:46     ` [tip:x86/pti] " tip-bot for Andrey Ryabinin
2018-01-14 23:37     ` tip-bot for Andrey Ryabinin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180114130756.zkysoiwaqfso2ml4@gmail.com \
    --to=mingo@kernel.org \
    --cc=aryabinin@virtuozzo.com \
    --cc=dvyukov@google.com \
    --cc=glider@google.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=tglx@linutronix.de \
    --cc=xiaolong.ye@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox