From mboxrd@z Thu Jan 1 00:00:00 1970 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753189AbeANWoS (ORCPT + 1 other); Sun, 14 Jan 2018 17:44:18 -0500 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:37230 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751341AbeANWoQ (ORCPT ); Sun, 14 Jan 2018 17:44:16 -0500 Date: Sun, 14 Jan 2018 14:44:15 -0800 From: "Paul E. McKenney" To: bigeasy@linutronix.de, fweisbec@gmail.com, linux-kernel@vger.kernel.org, hpa@zytor.com, peterz@infradead.org, mingo@kernel.org, tglx@linutronix.de, anna-maria@linutronix.de Cc: linux-tip-commits@vger.kernel.org Subject: Re: [tip:timers/urgent] timers: Unconditionally check deferrable base Reply-To: paulmck@linux.vnet.ibm.com References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-TM-AS-GCONF: 00 x-cbid: 18011422-0008-0000-0000-000002BFEFF2 X-IBM-SpamModules-Scores: X-IBM-SpamModules-Versions: BY=3.00008378; HX=3.00000241; KW=3.00000007; PH=3.00000004; SC=3.00000245; SDB=6.00975081; UDB=6.00494171; IPR=6.00755007; BA=6.00005775; NDR=6.00000001; ZLA=6.00000005; ZF=6.00000009; ZB=6.00000000; ZP=6.00000000; ZH=6.00000000; ZU=6.00000002; MB=3.00019036; XFM=3.00000015; UTC=2018-01-14 22:44:13 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 18011422-0009-0000-0000-000037EA1B28 Message-Id: <20180114224415.GX9671@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2018-01-14_14:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 lowpriorityscore=0 impostorscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1709140000 definitions=main-1801140323 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: On Sun, Jan 14, 2018 at 02:31:07PM -0800, tip-bot for Thomas Gleixner wrote: > Commit-ID: ed4bbf7910b28ce3c691aef28d245585eaabda06 > Gitweb: https://git.kernel.org/tip/ed4bbf7910b28ce3c691aef28d245585eaabda06 > Author: Thomas Gleixner > AuthorDate: Sun, 14 Jan 2018 23:19:49 +0100 > Committer: Thomas Gleixner > CommitDate: Sun, 14 Jan 2018 23:25:33 +0100 > > timers: Unconditionally check deferrable base > > When the timer base is checked for expired timers then the deferrable base > must be checked as well. This was missed when making the deferrable base > independent of base::nohz_active. Very cool, thank you! I have fired up some of the dreaded TREE01 tests. Thanx, Paul > Fixes: ced6d5c11d3e ("timers: Use deferrable base independent of base::nohz_active") > Signed-off-by: Thomas Gleixner > Cc: Anna-Maria Gleixner > Cc: Frederic Weisbecker > Cc: Peter Zijlstra > Cc: Sebastian Siewior > Cc: Paul McKenney > Cc: stable@vger.kernel.org > Cc: rt@linutronix.de > --- > kernel/time/timer.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/kernel/time/timer.c b/kernel/time/timer.c > index 89a9e1b..0bcf00e 100644 > --- a/kernel/time/timer.c > +++ b/kernel/time/timer.c > @@ -1696,7 +1696,7 @@ void run_local_timers(void) > hrtimer_run_queues(); > /* Raise the softirq only if required. */ > if (time_before(jiffies, base->clk)) { > - if (!IS_ENABLED(CONFIG_NO_HZ_COMMON) || !base->nohz_active) > + if (!IS_ENABLED(CONFIG_NO_HZ_COMMON)) > return; > /* CPU is awake, so check the deferrable base. */ > base++; >