From mboxrd@z Thu Jan 1 00:00:00 1970 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933465AbeAOKGR (ORCPT + 1 other); Mon, 15 Jan 2018 05:06:17 -0500 Received: from mx1.redhat.com ([209.132.183.28]:58156 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932627AbeAOKGP (ORCPT ); Mon, 15 Jan 2018 05:06:15 -0500 Date: Mon, 15 Jan 2018 11:06:11 +0100 From: Jiri Olsa To: Wang YanQing , acme@kernel.org, peterz@infradead.org, mingo@redhat.com, alexander.shishkin@linux.intel.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH] perf report: Provide libtraceevent with a kernel symbol resolver Message-ID: <20180115100611.GB14646@krava> References: <20180115044732.GB20373@udknight> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180115044732.GB20373@udknight> User-Agent: Mutt/1.9.1 (2017-09-22) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.32]); Mon, 15 Jan 2018 10:06:15 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: On Mon, Jan 15, 2018 at 12:47:32PM +0800, Wang YanQing wrote: > So that beautifiers wanting to resolve kernel function addresses to > names can do its work, and when we use "perf report" for output of > "perf kmem record", we will get kernel symbol output. > > Signed-off-by: Wang YanQing > --- > tools/perf/builtin-report.c | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/tools/perf/builtin-report.c b/tools/perf/builtin-report.c > index dd4df9a..7b65100 100644 > --- a/tools/perf/builtin-report.c > +++ b/tools/perf/builtin-report.c > @@ -1317,6 +1317,15 @@ int cmd_report(int argc, const char **argv) > report.range_num = 1; > } > > + if (session->tevent.pevent && > + pevent_set_function_resolver(session->tevent.pevent, > + machine__resolve_kernel_addr, > + &session->machines.host) < 0) { > + pr_err("%s: failed to set libtraceevent function resolver\n", > + __func__); > + return -1; > + } why not calling the wrapper trace_event__register_resolver? jirka > + > sort__setup_elide(stdout); > > ret = __cmd_report(&report); > -- > 1.8.5.6.2.g3d8a54e.dirty >