From mboxrd@z Thu Jan 1 00:00:00 1970 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S967278AbeAONNj (ORCPT + 1 other); Mon, 15 Jan 2018 08:13:39 -0500 Received: from mail.kernel.org ([198.145.29.99]:45860 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S967166AbeAONNi (ORCPT ); Mon, 15 Jan 2018 08:13:38 -0500 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A1A8D21795 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=acme@kernel.org Date: Mon, 15 Jan 2018 10:13:35 -0300 From: Arnaldo Carvalho de Melo To: Steven Rostedt Cc: Jiri Olsa , Wang YanQing , peterz@infradead.org, mingo@redhat.com, alexander.shishkin@linux.intel.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH] tools/lib/traceevent/event-parse: delete pevent_register_function Message-ID: <20180115131335.GA3542@kernel.org> References: <20180115045014.GC20373@udknight> <20180115100834.GC14646@krava> <20180115065427.5f947523@gandalf.local.home> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180115065427.5f947523@gandalf.local.home> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.9.1 (2017-09-22) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: Em Mon, Jan 15, 2018 at 06:54:27AM -0500, Steven Rostedt escreveu: > On Mon, 15 Jan 2018 11:08:34 +0100 > Jiri Olsa wrote: > > > On Mon, Jan 15, 2018 at 12:50:14PM +0800, Wang YanQing wrote: > > > After commit 4263cece22e3da94f16fbbcf71ce3807946d3ef3 > > > ("perf tools: Stop reading the kallsyms data from perf.data"), > > > there is no users of pevent_register_function in tree, so we > > > could just delete it. > > > > > > > I don't think you can remove this function, > > perf is not the only user there > > Correct. The tools/lib does not have the same requirements as the > kernel code. It's purpose is to be a library for other tools, not just > what is in tree. Otherwise, I would be happy to add trace-cmd to the > kernel proper, as that is where this code originated from. > > Don't delete those functions. They are required elsewhere. Right, I'll eventually add a 'perf test' entry to use those functions, testing its functionality so that this doesn't resurfaces in the future :-) - Arnaldo