* [PATCH] staging: unisys: change select to depends for subsystems
@ 2018-01-15 5:10 Randy Dunlap
2018-01-15 14:54 ` Greg Kroah-Hartman
0 siblings, 1 reply; 3+ messages in thread
From: Randy Dunlap @ 2018-01-15 5:10 UTC (permalink / raw)
To: devel@driverdev.osuosl.org, Greg Kroah-Hartman
Cc: David Kershner, sparmaintainer, LKML
From: Randy Dunlap <rdunlap@infradead.org>
Drivers should not 'select' a subsystem. Instead they should depend
on it. If the subsystem is disabled, the user probably did that for
a purpose and one driver shouldn't be changing that.
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: David Kershner <david.kershner@unisys.com>
Cc: sparmaintainer@unisys.com (Unisys internal)
Cc: devel@driverdev.osuosl.org
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
drivers/staging/unisys/Kconfig | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
--- lnx-415-rc8.orig/drivers/staging/unisys/Kconfig
+++ lnx-415-rc8/drivers/staging/unisys/Kconfig
@@ -4,8 +4,7 @@
menuconfig UNISYSSPAR
bool "Unisys SPAR driver support"
depends on X86_64 && !UML
- select PCI
- select ACPI
+ depends on PCI && ACPI
---help---
Support for the Unisys SPAR drivers
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] staging: unisys: change select to depends for subsystems
2018-01-15 5:10 [PATCH] staging: unisys: change select to depends for subsystems Randy Dunlap
@ 2018-01-15 14:54 ` Greg Kroah-Hartman
2018-01-15 18:51 ` Randy Dunlap
0 siblings, 1 reply; 3+ messages in thread
From: Greg Kroah-Hartman @ 2018-01-15 14:54 UTC (permalink / raw)
To: Randy Dunlap
Cc: devel@driverdev.osuosl.org, David Kershner, sparmaintainer, LKML
On Sun, Jan 14, 2018 at 09:10:54PM -0800, Randy Dunlap wrote:
> From: Randy Dunlap <rdunlap@infradead.org>
>
> Drivers should not 'select' a subsystem. Instead they should depend
> on it. If the subsystem is disabled, the user probably did that for
> a purpose and one driver shouldn't be changing that.
>
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: David Kershner <david.kershner@unisys.com>
> Cc: sparmaintainer@unisys.com (Unisys internal)
> Cc: devel@driverdev.osuosl.org
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> ---
> drivers/staging/unisys/Kconfig | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> --- lnx-415-rc8.orig/drivers/staging/unisys/Kconfig
> +++ lnx-415-rc8/drivers/staging/unisys/Kconfig
> @@ -4,8 +4,7 @@
> menuconfig UNISYSSPAR
> bool "Unisys SPAR driver support"
> depends on X86_64 && !UML
> - select PCI
> - select ACPI
> + depends on PCI && ACPI
> ---help---
> Support for the Unisys SPAR drivers
>
Does not apply to my tree at all :(
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] staging: unisys: change select to depends for subsystems
2018-01-15 14:54 ` Greg Kroah-Hartman
@ 2018-01-15 18:51 ` Randy Dunlap
0 siblings, 0 replies; 3+ messages in thread
From: Randy Dunlap @ 2018-01-15 18:51 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: devel@driverdev.osuosl.org, David Kershner, sparmaintainer, LKML
On 01/15/18 06:54, Greg Kroah-Hartman wrote:
> On Sun, Jan 14, 2018 at 09:10:54PM -0800, Randy Dunlap wrote:
>> From: Randy Dunlap <rdunlap@infradead.org>
>>
>> Drivers should not 'select' a subsystem. Instead they should depend
>> on it. If the subsystem is disabled, the user probably did that for
>> a purpose and one driver shouldn't be changing that.
>>
>> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
>> Cc: David Kershner <david.kershner@unisys.com>
>> Cc: sparmaintainer@unisys.com (Unisys internal)
>> Cc: devel@driverdev.osuosl.org
>> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
>> ---
>> drivers/staging/unisys/Kconfig | 3 +--
>> 1 file changed, 1 insertion(+), 2 deletions(-)
>>
>> --- lnx-415-rc8.orig/drivers/staging/unisys/Kconfig
>> +++ lnx-415-rc8/drivers/staging/unisys/Kconfig
>> @@ -4,8 +4,7 @@
>> menuconfig UNISYSSPAR
>> bool "Unisys SPAR driver support"
>> depends on X86_64 && !UML
>> - select PCI
>> - select ACPI
>> + depends on PCI && ACPI
>> ---help---
>> Support for the Unisys SPAR drivers
>>
>
> Does not apply to my tree at all :(
Bad Randy. Patch is not needed... which is good.
--
~Randy
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-01-15 18:51 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-01-15 5:10 [PATCH] staging: unisys: change select to depends for subsystems Randy Dunlap
2018-01-15 14:54 ` Greg Kroah-Hartman
2018-01-15 18:51 ` Randy Dunlap
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox