From mboxrd@z Thu Jan 1 00:00:00 1970 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965880AbeAOOy1 (ORCPT + 1 other); Mon, 15 Jan 2018 09:54:27 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:50796 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932490AbeAOOy0 (ORCPT ); Mon, 15 Jan 2018 09:54:26 -0500 Date: Mon, 15 Jan 2018 15:54:22 +0100 From: Greg Kroah-Hartman To: Randy Dunlap Cc: "devel@driverdev.osuosl.org" , David Kershner , sparmaintainer@unisys.com, LKML Subject: Re: [PATCH] staging: unisys: change select to depends for subsystems Message-ID: <20180115145422.GA4611@kroah.com> References: <21c1422d-9941-6c1b-6ade-f66ac14fcc81@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <21c1422d-9941-6c1b-6ade-f66ac14fcc81@infradead.org> User-Agent: Mutt/1.9.2 (2017-12-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: On Sun, Jan 14, 2018 at 09:10:54PM -0800, Randy Dunlap wrote: > From: Randy Dunlap > > Drivers should not 'select' a subsystem. Instead they should depend > on it. If the subsystem is disabled, the user probably did that for > a purpose and one driver shouldn't be changing that. > > Signed-off-by: Randy Dunlap > Cc: David Kershner > Cc: sparmaintainer@unisys.com (Unisys internal) > Cc: devel@driverdev.osuosl.org > Cc: Greg Kroah-Hartman > --- > drivers/staging/unisys/Kconfig | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > --- lnx-415-rc8.orig/drivers/staging/unisys/Kconfig > +++ lnx-415-rc8/drivers/staging/unisys/Kconfig > @@ -4,8 +4,7 @@ > menuconfig UNISYSSPAR > bool "Unisys SPAR driver support" > depends on X86_64 && !UML > - select PCI > - select ACPI > + depends on PCI && ACPI > ---help--- > Support for the Unisys SPAR drivers > Does not apply to my tree at all :(