From: Russell King <linux@armlinux.org.uk>
To: Wolfram Sang <wsa@the-dreams.de>
Cc: Arnd Bergmann <arnd@arndb.de>,
linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] i2c: acorn: add MODULE_LICENSE tag
Date: Mon, 15 Jan 2018 17:19:20 +0000 [thread overview]
Message-ID: <20180115171920.GA32698@flint.armlinux.org.uk> (raw)
In-Reply-To: <20180115171027.ynorej3x7nal7ttj@ninjato>
On Mon, Jan 15, 2018 at 06:10:28PM +0100, Wolfram Sang wrote:
> On Thu, Jan 11, 2018 at 11:37:45AM +0100, Arnd Bergmann wrote:
> > As of v4.15, Kbuild warns about missing MODULE_LICENSE tags:
> >
> > WARNING: modpost: missing MODULE_LICENSE() in drivers/i2c/busses/i2c-acorn.o
> >
> > This adds a license, author and description tag, matching the
> > comment at the start of the acorn i2c driver.
> >
> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>
> Looks good, but since rmk is still around, let's add him to CC...
>
> > ---
> > drivers/i2c/busses/i2c-acorn.c | 4 ++++
> > 1 file changed, 4 insertions(+)
> >
> > diff --git a/drivers/i2c/busses/i2c-acorn.c b/drivers/i2c/busses/i2c-acorn.c
> > index 9d7be5af2bf2..6463189ca183 100644
> > --- a/drivers/i2c/busses/i2c-acorn.c
> > +++ b/drivers/i2c/busses/i2c-acorn.c
> > @@ -94,3 +94,7 @@ static int __init i2c_ioc_init(void)
> > }
> >
> > module_init(i2c_ioc_init);
> > +
> > +MODULE_AUTHOR("Russell King <rmk@arm.linux.org.uk>");
linux@armlinux.org.uk please - dspam on _this_ account files such mails
into the spam mailbox.
Thanks.
> > +MODULE_DESCRIPTION("ARM IOC/IOMD i2c driver");
> > +MODULE_LICENSE("GPL v2");
> > --
> > 2.9.0
> >
--
Russell King
ARM architecture Linux Kernel maintainer
next prev parent reply other threads:[~2018-01-15 17:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-11 10:37 [PATCH] i2c: acorn: add MODULE_LICENSE tag Arnd Bergmann
2018-01-15 17:10 ` Wolfram Sang
2018-01-15 17:19 ` Russell King [this message]
2018-01-15 20:31 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180115171920.GA32698@flint.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=arnd@arndb.de \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox