From: Josh Poimboeuf <jpoimboe@redhat.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Borislav Petkov <bp@alien8.de>,
David Woodhouse <dwmw2@infradead.org>,
linux-kernel@vger.kernel.org, Dave Hansen <dave.hansen@intel.com>,
Ashok Raj <ashok.raj@intel.com>,
Thomas Gleixner <tglx@linutronix.de>,
Tim Chen <tim.c.chen@linux.intel.com>,
Andy Lutomirski <luto@kernel.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
Greg KH <gregkh@linuxfoundation.org>,
Andrea Arcangeli <aarcange@redhat.com>,
Andi Kleen <ak@linux.intel.com>,
Arjan Van De Ven <arjan.van.de.ven@intel.com>,
Dan Williams <dan.j.williams@intel.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Jun Nakajima <jun.nakajima@intel.com>,
Asit Mallick <asit.k.mallick@intel.com>
Subject: Re: [PATCH 2/4] objtool: Implement jump_assert for _static_cpu_has()
Date: Mon, 15 Jan 2018 14:30:32 -0600 [thread overview]
Message-ID: <20180115203032.rykendkdrxtjrtf7@treble> (raw)
In-Reply-To: <20180115201545.GO3397@worktop>
On Mon, Jan 15, 2018 at 09:15:45PM +0100, Peter Zijlstra wrote:
> On Mon, Jan 15, 2018 at 01:11:51PM -0600, Josh Poimboeuf wrote:
> > Well, to clarify, it would solve _some_ of the problem. Maybe even most
> > of the problem. We'd still need to special-case jump labels in objtool
> > (like in 1/4), but that's probably not a big deal.
> >
> > So, contradicting my previous answer here... yes, it would help.
>
> OK, saves me from having to argue otherwise. My argument would've been
> that jump labels are fully described and don't need further annotation.
>
> Yes, Boris' proposal would certainly help with the alternative stuff.
Fair enough. So either annotating _static_cpu_has() or adding an
alt_instr flag works for me.
--
Josh
next prev parent reply other threads:[~2018-01-15 20:30 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-15 16:44 [PATCH 0/4] objtool validation of static branches Peter Zijlstra
2018-01-15 16:44 ` [PATCH 1/4] objtool: Implement base jump_assert support Peter Zijlstra
2018-01-15 17:39 ` Josh Poimboeuf
2018-01-15 18:00 ` Peter Zijlstra
2018-01-15 16:44 ` [PATCH 2/4] objtool: Implement jump_assert for _static_cpu_has() Peter Zijlstra
2018-01-15 18:04 ` Josh Poimboeuf
2018-01-15 18:12 ` Peter Zijlstra
2018-01-15 18:34 ` Josh Poimboeuf
2018-01-15 18:59 ` Borislav Petkov
2018-01-15 19:08 ` Josh Poimboeuf
2018-01-15 19:11 ` Josh Poimboeuf
2018-01-15 19:15 ` Borislav Petkov
2018-01-15 20:15 ` Peter Zijlstra
2018-01-15 20:30 ` Josh Poimboeuf [this message]
2018-01-15 16:44 ` [PATCH 3/4] x86/jump_label: Implement arch_static_assert() Peter Zijlstra
2018-01-15 17:22 ` Josh Poimboeuf
2018-01-15 17:41 ` David Woodhouse
2018-01-15 17:58 ` Peter Zijlstra
2018-01-15 18:28 ` Josh Poimboeuf
2018-01-15 16:44 ` [PATCH 4/4] x86: Reindent _static_cpu_has Peter Zijlstra
2018-01-15 17:15 ` Josh Poimboeuf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180115203032.rykendkdrxtjrtf7@treble \
--to=jpoimboe@redhat.com \
--cc=aarcange@redhat.com \
--cc=ak@linux.intel.com \
--cc=arjan.van.de.ven@intel.com \
--cc=ashok.raj@intel.com \
--cc=asit.k.mallick@intel.com \
--cc=bp@alien8.de \
--cc=dan.j.williams@intel.com \
--cc=dave.hansen@intel.com \
--cc=dwmw2@infradead.org \
--cc=gregkh@linuxfoundation.org \
--cc=jun.nakajima@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=pbonzini@redhat.com \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=tim.c.chen@linux.intel.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox