From: Darren Hart <dvhart@infradead.org>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: Platform Driver <platform-driver-x86@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Andy Shevchenko <andy@infradead.org>
Subject: Re: [PATCH] platform/x86: have ACPI_CMPC use depends instead of select for INPUT
Date: Mon, 15 Jan 2018 12:42:29 -0800 [thread overview]
Message-ID: <20180115204229.GA11094@fury> (raw)
In-Reply-To: <913480bb-d06a-3f13-e8fc-20f83ff499a0@infradead.org>
On Sun, Jan 14, 2018 at 09:11:18PM -0800, Randy Dunlap wrote:
> From: Randy Dunlap <rdunlap@infradead.org>
>
> Drivers should not 'select' a subsystem. Instead they should depend
> on it. If the subsystem is disabled, the user probably did that for
> a purpose and one driver shouldn't be changing that.
>
> This also makes all platform/x86/ drivers consistent w.r.t depending on
> INPUT instead of selecting it.
>
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Darren Hart <dvhart@infradead.org>
> Cc: Andy Shevchenko <andy@infradead.org>
> Cc: platform-driver-x86@vger.kernel.org
Thanks Randy, queued.
--
Darren Hart
VMware Open Source Technology Center
prev parent reply other threads:[~2018-01-15 20:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-15 5:11 [PATCH] platform/x86: have ACPI_CMPC use depends instead of select for INPUT Randy Dunlap
2018-01-15 20:42 ` Darren Hart [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180115204229.GA11094@fury \
--to=dvhart@infradead.org \
--cc=andy@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=rdunlap@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox