From mboxrd@z Thu Jan 1 00:00:00 1970 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750837AbeAOUmc (ORCPT + 1 other); Mon, 15 Jan 2018 15:42:32 -0500 Received: from bombadil.infradead.org ([65.50.211.133]:42571 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750716AbeAOUma (ORCPT ); Mon, 15 Jan 2018 15:42:30 -0500 Date: Mon, 15 Jan 2018 12:42:29 -0800 From: Darren Hart To: Randy Dunlap Cc: Platform Driver , LKML , Andy Shevchenko Subject: Re: [PATCH] platform/x86: have ACPI_CMPC use depends instead of select for INPUT Message-ID: <20180115204229.GA11094@fury> References: <913480bb-d06a-3f13-e8fc-20f83ff499a0@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <913480bb-d06a-3f13-e8fc-20f83ff499a0@infradead.org> User-Agent: Mutt/1.8.0 (2017-02-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: On Sun, Jan 14, 2018 at 09:11:18PM -0800, Randy Dunlap wrote: > From: Randy Dunlap > > Drivers should not 'select' a subsystem. Instead they should depend > on it. If the subsystem is disabled, the user probably did that for > a purpose and one driver shouldn't be changing that. > > This also makes all platform/x86/ drivers consistent w.r.t depending on > INPUT instead of selecting it. > > Signed-off-by: Randy Dunlap > Cc: Darren Hart > Cc: Andy Shevchenko > Cc: platform-driver-x86@vger.kernel.org Thanks Randy, queued. -- Darren Hart VMware Open Source Technology Center