From: Heiko Carstens <heiko.carstens@de.ibm.com>
To: Eugene Syromiatnikov <esyr@redhat.com>
Cc: linux-s390@vger.kernel.org,
Martin Schwidefsky <schwidefsky@de.ibm.com>,
Paul Gortmaker <paul.gortmaker@windriver.com>,
Philippe Ombredanne <pombredanne@nexb.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Kate Stewart <kstewart@linuxfoundation.org>,
Thomas Gleixner <tglx@linutronix.de>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] s390: fix handling of -1 in set{,fs}[gu]id16 syscalls
Date: Mon, 15 Jan 2018 23:36:52 +0100 [thread overview]
Message-ID: <20180115223652.GB3054@osiris> (raw)
In-Reply-To: <20180115193817.GA8145@asgard.redhat.com>
On Mon, Jan 15, 2018 at 08:38:17PM +0100, Eugene Syromiatnikov wrote:
> For some reason, the implementation of some 16-bit ID system calls
> (namely, setuid16/setgid16 and setfsuid16/setfsgid16) used type cast
> instead of low2highgid/low2highuid macros for converting [GU]IDs, which
> led to incorrect handling of value of -1 (which ought to be considered
> invalid).
>
> Discovered by strace test suite.
>
> Cc: stable@vger.kernel.org
> Signed-off-by: Eugene Syromiatnikov <esyr@redhat.com>
> ---
> arch/s390/kernel/compat_linux.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
Applied, thanks!
prev parent reply other threads:[~2018-01-15 22:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-15 11:52 [PATCH] s390: fix setgid16/setuid16 handling of -1 Eugene Syromiatnikov
2018-01-15 12:06 ` Greg Kroah-Hartman
2018-01-15 15:19 ` Heiko Carstens
2018-01-15 19:38 ` [PATCH v2] s390: fix handling of -1 in set{,fs}[gu]id16 syscalls Eugene Syromiatnikov
2018-01-15 22:36 ` Heiko Carstens [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180115223652.GB3054@osiris \
--to=heiko.carstens@de.ibm.com \
--cc=esyr@redhat.com \
--cc=gregkh@linuxfoundation.org \
--cc=kstewart@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=paul.gortmaker@windriver.com \
--cc=pombredanne@nexb.com \
--cc=schwidefsky@de.ibm.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox