From mboxrd@z Thu Jan  1 00:00:00 1970
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1750892AbeAPDL3 (ORCPT <rfc822;ralf@linux-mips.org> + 1 other);
        Mon, 15 Jan 2018 22:11:29 -0500
Received: from mail-wr0-f196.google.com ([209.85.128.196]:36212 "EHLO
        mail-wr0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1750716AbeAPDL1 (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 15 Jan 2018 22:11:27 -0500
X-Google-Smtp-Source: ACJfBos2HjrBTa4qSCpdIoCGlLJdrH8MNf8ScTyCNWpeMJsHTQHSiVHWBJcG5zMez6Jt3+c8ousEQQ==
Date: Tue, 16 Jan 2018 04:11:23 +0100
From: Ingo Molnar <mingo@kernel.org>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: "H. Peter Anvin" <hpa@zytor.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, x86@kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 5/6] x86/boot: Allow longer parameter list for
 earlyprintk
Message-ID: <20180116031123.35emo6eiqicbx67q@gmail.com>
References: <20180114143254.15429-1-andriy.shevchenko@linux.intel.com>
 <20180114143254.15429-5-andriy.shevchenko@linux.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20180114143254.15429-5-andriy.shevchenko@linux.intel.com>
User-Agent: NeoMutt/20170609 (1.8.3)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>


* Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:

> Allow longer parameter list for earlyprintk to support new coming
> parameters.
> 
> No functional change intended.
> 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
>  arch/x86/boot/early_serial_console.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/x86/boot/early_serial_console.c b/arch/x86/boot/early_serial_console.c
> index 8cb7b0e8fe98..ef10926ab9e5 100644
> --- a/arch/x86/boot/early_serial_console.c
> +++ b/arch/x86/boot/early_serial_console.c
> @@ -90,7 +90,7 @@ static void early_serial_init(unsigned long port, int baud)
>  static void parse_earlyprintk(void)
>  {
>  	int baud = DEFAULT_BAUD;
> -	char arg[32];
> +	char arg[64];
>  	int pos = 0;
>  	unsigned long port = 0;

BTW., what happens if the parsed string is longer than this buffer?

Thanks,

	Ingo